Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319580 - Open Plug-in Artifact dialog shows wrong labels
Summary: Open Plug-in Artifact dialog shows wrong labels
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-12 10:27 EDT by Markus Keller CLA
Modified: 2010-08-03 05:22 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-07-12 10:27:34 EDT 
I20100706-0800

- new workspace
- add all plug-ins to Java search
- Open Plug-in Artifact...
- type "*.contentTypes"
=> labels look OK
- press Arrow Down key twice
=> label for first entry changed from org.eclipse.core.contentTypes to org.eclipse.runtime.contentTypes

The bug is in the implementation of org.eclipse.pde.internal.core.plugin.PluginExtensionPoint#equals(Object), which doesn't compare enough properties.

In this case, comparing getFullId() or getParent() would fix the problem, but there may be more properties missing.
Comment 1 Curtis Windatt CLA 2010-07-12 12:44:08 EDT 
Using getFullID instead of getID makes sense here.
Comment 2 Curtis Windatt CLA 2010-07-12 12:46:58 EDT 
Fixed in HEAD.

As Markus says, there could be other properties included in the equals, but id, name and schema should be enough.
Comment 3 Ankur Sharma CLA 2010-08-03 05:22:27 EDT 
Verified in I20100802-1800