Community
Participate
Working Groups
Created attachment 173959 [details] compile-jarinjarloader.patch Please compile jar-in-jar-loader.zip, because we should remove this binary file from the source tarball. Patch from Niels Thykier attached.
Why do we have this as a prebootstrap? Do we really need this before bootstrapping? I doubt it. My first thought is that this should be fixed in o.e.jdt.ui build process.
Created attachment 177181 [details] Custom call back hooks. Hi, What do you think of this custom call back as alternative? I intend to push to JDT, but I would prefer knowing I am on the right track before disturbing them. ~Niels
Seems good for me. Please push it up so we can get the opinion of upstream devs.
Hi Now that #324794 has been fixed , this can be trivially fixed by removing jar-in-jar-loader.zip from the tarball and upgrading to a version of eclipse that includes the fix. Regardless, the current patch here is no longer needed. ~Niels
Niels, does https://bugs.eclipse.org/bugs/attachment.cgi?id=181331 apply cleanly to 3.6.x?
(In reply to comment #5) > Niels, does https://bugs.eclipse.org/bugs/attachment.cgi?id=181331 apply > cleanly to 3.6.x? Hey, It has already been applied by Markus Keller w. minor correction (see bug 324794) on the 2010-10-20. :) ~Niels
Oh, I was assuming he applied it to HEAD. If so, does it apply to 3.6.x?
Hey It applies cleanly in the eclipse-3.6 checkout I have, which is rather old (from July I think?)[1]. We got this from e-b, so unless e-b updated its checkout/tarball since then it will apply cleanly. Even if e-b did update the tarball, I doubt it would affect this patch (unless the tarball was built with the patched code). ~Niels [1] Note I did not have time to do an "ant applyPatches", but using grep we did not appear to have any conflicting patches in patches/: $ grep org.eclipse.jdt.ui patches/* $
I created a tarball of the SDK sources without the zip, created a patch to apply the patch for this and ran a build. Things look fine to me (build finished, SDK starts up, jdt.ui loaded) so I'll apply things tomorrow and upload a new tarball without the jar-in-jar-loader zip included.
Committed in revision 27118. New 3.6.1 tarball with removed jar-in-jar-loader has: 1261b739e9b66d1f1bb1439899bae320 (md5sum) 7ec5109da0038a9dc0d23eeac4b2078183fe719c (sha1sum)
Resolving
