Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319474 - [eclipse-build] [debian] Fix bashism in eclipse-pde.build-add-package-build.patch
Summary: [eclipse-build] [debian] Fix bashism in eclipse-pde.build-add-package-build.p...
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: eclipse-build (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6.1   Edit
Assignee: Andrew Overholt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-10 19:48 EDT by Benjamin Drung CLA
Modified: 2011-06-23 16:35 EDT (History)
3 users (show)

See Also:

Attachments
fix-bashism.patch (1.75 KB, patch)
2010-07-10 19:48 EDT, Benjamin Drung CLA 		overholt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Drung CLA 2010-07-10 19:48:05 EDT 
Created attachment 173957 [details]
fix-bashism.patch

Please fix bashism in eclipse-pde.build-add-package-build.patch. Attached the patch from Adnan Hodzic <adnan@foolcontrol.org>.
Comment 1 Andrew Overholt CLA 2010-07-14 11:49:09 EDT 
Thanks for the patch.  Adnan will have to comment here indicating acceptance and licensing of the EPL for us to commit it.  It looks fine.
Comment 2 Benjamin Drung CLA 2010-07-14 11:53:12 EDT 
This patch is part of the Debian package and therefore licensed under EPL-1.0, too.
Comment 3 Andrew Overholt CLA 2010-07-14 12:12:01 EDT 
That's fine, but unless you wrote it, Benjamin, the contributor must state here that they are okay with it being contributed to eclipse.org.
Comment 4 Adnan Hodzic CLA 2010-07-14 14:12:01 EDT 
Andrew, yes it's okay, and I definitely want it to be contributed to Eclipse as well. 


Adnan
Comment 5 Andrew Overholt CLA 2010-07-14 15:52:36 EDT 
Thanks, Adnan.  Committed in revision #25266.
Comment 6 Andrew Overholt CLA 2010-07-14 16:39:11 EDT 
Committed to e3.6 branch as well (revision #25267).