Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319393 - org.eclipse.virgo.kernel.dm is not used -- remove it
Summary: org.eclipse.virgo.kernel.dm is not used -- remove it
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 minor (vote)
Target Milestone: 2.1.0.M05-incubation   Edit
Assignee: Chris Frost CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 319099 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-09 10:07 EDT by Steve Powell CLA
Modified: 2010-10-05 03:58 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Powell CLA 2010-07-09 10:07:06 EDT 
We need to check that this isn't actually used at all, of course.

There are many references in the code to it, however, and these will all need to be removed to keep tests running correctly.

Here is a snapshot of the files that contain the string "org.eclipse.virgo.kernel.dm":

In org.eclipse.virgo.kernel/ ...
    build-kernel/lib/org.eclipse.virgo.kernel.launch.properties
    build-kernel/build.xml
    org.eclipse.virgo.kernel/ivy.xml
    org.eclipse.virgo.kernel.dm/build.xml
    org.eclipse.virgo.kernel.dm/template.mf
    org.eclipse.virgo.kernel.dm/.project
    org.eclipse.virgo.kernel.dm/src/main/java/org/eclipse/virgo/kernel/dm/internal/StandardServiceProxyInspector.java
    org.eclipse.virgo.kernel.dm/src/main/java/org/eclipse/virgo/kernel/dm/internal/StandardBundleDelegatingClassLoaderFactory.java
    org.eclipse.virgo.kernel.dm/src/main/resources/META-INF/spring/kernel-dm-context.xml
    org.eclipse.virgo.kernel.test/ivy.xml
    org.eclipse.virgo.kernel.test/src/test/java/org/eclipse/virgo/kernel/dm/test/ModuleBeanFactoryPostProcessorTests.java
    org.eclipse.virgo.kernel.test/src/test/resources/META-INF/MANIFEST.MF
    org.eclipse.virgo.kernel.test/src/test/resources/test.config.properties
    org.eclipse.virgo.kernel.deployer.test/.classpath
    org.eclipse.virgo.kernel.deployer.test/src/test/resources/META-INF/test.config.properties
    org.eclipse.virgo.kernel.deployer.test/src/test/resources/META-INF/spring256.test.config.properties

In org.eclipse.virgo.apps/
    org.eclipse.virgo.apps.repository.test/src/test/resources/META-INF/test.config.properties

In org.eclipse.virgo.web/
    org.eclipse.virgo.web.core/ivy.xml
    org.eclipse.virgo.web.test/src/test/resources/META-INF/test.config.properties

In org.eclipse.virgo.documentation/
    user-guide/src/log-codes.xml

Note: The interfaces ServiceProxyInspector and BundleDelegatingClassLoaderFactory are defined in org.eclipse.virgo.kernel.module which is a package in org.eclipse.virgo.kernel.deployer.  ...dm creates implementations (and beans) for these interfaces, but no-one uses them.  If the project ....dm is removed then the interfaces can be as well.
Comment 1 Glyn Normington CLA 2010-07-16 07:25:05 EDT 
*** Bug 319099 has been marked as a duplicate of this bug. ***
Comment 2 Steve Powell CLA 2010-07-16 07:41:56 EDT 
Whoops -- looks like I raised both of them!  :-) Thanks for spotting this, Glyn.
Comment 3 Glyn Normington CLA 2010-09-17 08:36:02 EDT 
Steve's note from the duplicate bug:

The bundle is installed and started when kernel starts up, and publishes (via
spring) some services against some interfaces (in
org.eclipse.virgo.kernel.module). Neither the services nor the interfaces are
used.

There is nothing else in this bundle (not even tests).  It (and the interfaces
it uses) can be removed.

The bundle should also be removed from the kernel launch list (in main and test
config files).

NOTE: Spring beans set up the bundle -- there is no activator -- and there are
some service references there also which are not used anywhere.

This is a minor performance bug.
Comment 4 Chris Frost CLA 2010-09-17 10:35:28 EDT 
Kernel.dm has been removed, all references to it in kernel and other repos have also been deleted.
Comment 5 Glyn Normington CLA 2010-09-20 05:19:32 EDT 
closing
Comment 6 Glyn Normington CLA 2010-09-27 08:34:27 EDT 
RC1 is planned instead of milestone 5.