Community
Participate
Working Groups
Created attachment 173830 [details] Fix org.eclipse.cdt.dsf.gdb.internal.ui.viewmodel.Messages expects its property file to be named Messages.properties instead of messages.properties. The consequence is a missing string for an error path, which explains why we didn't notice it before. This was actually found in Bug 302121.
John can you confirm this makes sense to you? Also, renaming a messages.properties to Messages.properties is allowed for the 7_0 branch, right? If not, then we can fix this in Messages.java I committed this to HEAD but not to 7_0 until I know if its allowed.
Marc, changing the case of a file in CVS is a sticky situation when the repository is used on Windows, due to the case-insensitive nature of the file system. In this case, your commit causes problems for developers updating their sources on Windows. Problem writing resource '/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.properties'. A resource already exists on disk 'C:\eclipse_3.6\workspace_cdt\org.eclipse.cdt.dsf.gdb.ui\src\org\eclipse\cdt\dsf\gdb\internal\ui\viewmodel\Messages.properties'. A resource already exists on disk 'C:\eclipse_3.6\workspace_cdt\org.eclipse.cdt.dsf.gdb.ui\src\org\eclipse\cdt\dsf\gdb\internal\ui\viewmodel\Messages.properties'. Probably the best thing is to indeed change Messages.java to simply specify the fully qualified message bundle name (with lower case messages.propertes) in its NLS.initializeMessages() call.
*** cdt cvs genie on behalf of mkhouzam *** Bug 319336: Wrongly names properties file [-] messages.properties http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/messages.properties?root=Tools_Project&view=markup [+] Messages.properties http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.properties?root=Tools_Project&revision=1.1&view=markup
(In reply to comment #2) > Marc, changing the case of a file in CVS is a sticky situation when the > repository is used on Windows, due to the case-insensitive nature of the file > system. In this case, your commit causes problems for developers updating their > sources on Windows. > > Problem writing resource > '/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.properties'. > A resource already exists on disk > 'C:\eclipse_3.6\workspace_cdt\org.eclipse.cdt.dsf.gdb.ui\src\org\eclipse\cdt\dsf\gdb\internal\ui\viewmodel\Messages.properties'. > A resource already exists on disk > 'C:\eclipse_3.6\workspace_cdt\org.eclipse.cdt.dsf.gdb.ui\src\org\eclipse\cdt\dsf\gdb\internal\ui\viewmodel\Messages.properties'. > > Probably the best thing is to indeed change Messages.java to simply specify the > fully qualified message bundle name (with lower case messages.propertes) in its > NLS.initializeMessages() call. But I'm sure you've done this before. Or were you changing the name of the file in more than just the upper/lower case?
Created attachment 173907 [details] Fix to avoid Windows problem This fix will seem weird, but here is my thought. The problem happens when people have 'messages.properties' in their workspace and synch to get 'Messages.properties. So, this patch renames the file in question to 'Message.properties' (note the missing 's'). This will no longer cause a problem on Windows. It will also allow us to move back to Messages.properties (which really should be the name) in some months after most people have synched with the repo and got rid of the original messages.properties. Committed to HEAD. For 7_0 I'll come up with a straightforward solution since it is not as important for the future.
Created attachment 173908 [details] mylyn/context/zip
*** cdt cvs genie on behalf of mkhouzam *** Bug 319336: Changing the case of a file is causing problems on Windows. This change make the name of the file different. [-] Messages.properties http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.properties?root=Tools_Project&view=markup [+] Message.properties http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Message.properties?root=Tools_Project&revision=1.1&view=markup [*] Messages.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.java?root=Tools_Project&r1=1.2&r2=1.3
Created attachment 173987 [details] Fix for 7_0 branch This simply makes a change in Messages.java to point to the correct properties file. Committed to 7_0
John, is that good with you?
*** cdt cvs genie on behalf of mkhouzam *** Bug 319336: Point to the right properties file. We don't want to rename the properties file itself because the renaming would simply be a change in lower-case to upper-case which causes problem when replacing the file on Windows. [*] Messages.java 1.2.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/Messages.java?root=Tools_Project&r1=1.2&r2=1.2.2.1
