Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319332 - Support agents using hostnames in IPeer.ATTR_IP_HOST
Summary: Support agents using hostnames in IPeer.ATTR_IP_HOST
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-08 19:29 EDT by John Cortell CLA
Modified: 2010-08-09 11:01 EDT (History)
1 user (show)

See Also:
ed.swartz: review+

Attachments
Solution (2.04 KB, patch)
2010-07-08 19:29 EDT, John Cortell CLA 		john.cortell: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-07-08 19:29:03 EDT 
The Freescale TCF agents uses the local hostname instead of a numeric IP address when advertising its peers via discovery. I asked Eugene about this. He says that's fine, but receiving agents are not required to handle a hostname.

It would be a relatively low runtime cost enhancement to EDC's TCFServiceManager. I've attached my proposed solution. Will commit unless if there are no objections
Comment 1 John Cortell CLA 2010-07-08 19:29:41 EDT 
Created attachment 173829 [details]
Solution
Comment 2 John Cortell CLA 2010-07-08 19:31:30 EDT 
[Correction] Will commit if there are no objections
Comment 3 John Cortell CLA 2010-07-27 14:14:37 EDT 
Committed to HEAD
Comment 4 John Cortell CLA 2010-07-27 14:14:53 EDT 
Ed, please review.
Comment 5 CDT Genie CLA 2010-07-27 14:23:02 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 319332: Support agents using hostnames in IPeer.ATTR_IP_HOST

[*] TCFServiceManager.java 1.26 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/TCFServiceManager.java?root=Tools_Project&r1=1.25&r2=1.26
Comment 6 Ed Swartz CLA 2010-08-09 11:01:51 EDT 
Looks good to me.