Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319329 - site.p2 doesn't include multiple versions of a bundle, when feature export does
Summary: site.p2 doesn't include multiple versions of a bundle, when feature export does
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-08 19:05 EDT by Jason Barkanic CLA
Modified: 2019-02-25 14:40 EST (History)
2 users (show)

See Also:


Attachments
Test Projects archive (9.55 KB, application/x-zip-compressed)
2010-07-19 11:28 EDT, Jason Barkanic CLA
thomas: iplog+
Details
Target Platform (1.01 MB, application/x-zip-compressed)
2010-07-19 11:29 EDT, Jason Barkanic CLA
thomas: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Barkanic CLA 2010-07-08 19:05:25 EDT
Build Identifier: I20100608-0911

Two versions of a bundle exist in the target platform.  One feature includes version 1.0.0, another feature includes 2.0.0.  When site.p2 is invoked, the resulting repo only contains version 2.0.0 of the bundle, when it should contain both.  Invoking an export feature correctly results in a repo that contains both versions of the bundle.

Reproducible: Always

Steps to Reproduce:
1. Two versions of a bundle in the target platform
2. Two features that include each of the bundles by explicit version. Example: 
    <plugin
         id="com.example.bundle"
         download-size="0"
         install-size="0"
         version="1.0.0"
         unpack="false"/>
3. Run site.p2 on a top level feature
4. Examine repo
Comment 1 Thomas Hallgren CLA 2010-07-19 04:32:51 EDT
Buckminster should allow two versions of the same bundle if the version difference is more significant then just the qualifier. Buckminster will not allow 1.0.0.abc and 1.0.0.xyz but it should allow 1.0.0.abc and 1.1.0.abc.

Can you please attach an example that provokes the problem?
Comment 2 Jason Barkanic CLA 2010-07-19 11:28:55 EDT
Created attachment 174634 [details]
Test Projects archive

Archive file with test projects and features.
Comment 3 Jason Barkanic CLA 2010-07-19 11:29:51 EDT
Created attachment 174635 [details]
Target Platform

Target Platform files
Comment 4 Jason Barkanic CLA 2010-07-19 11:41:33 EDT
I attached a project archive and target platform files.  I'm sorry if it is confusing, but there are three bundles: "one, two, and three".  The target contains two different versions of bundle one.  Bundles two and three require one but have different (non overlapping) version range constraints. 

I created two different features to package bundle two and three.  Each include their respective bundle, and also the needed version of one.

Finally there is a top level feature on which to invoke site.p2 that includes the other features.

The repo resulting from invoking site.p2 will only contain a single version of bundle one.  The repo resulting from invoking a feature export through the PDE tooling will contain both versions of bundle one (which is the desired behavior).
Comment 5 Thomas Hallgren CLA 2010-07-20 03:50:48 EDT
The cspec dependencies had a bogus version range. This is now corrected.

The fix was committed to helios-maintenance, rev 11507.

Thanks Jason, for an excellent test case.
Comment 6 Thomas Hallgren CLA 2010-07-20 03:52:30 EDT
*** Bug 320345 has been marked as a duplicate of this bug. ***
Comment 7 Thomas Hallgren CLA 2010-07-21 09:30:01 EDT
I added a JUnit test case based on the attached sample to the Buckminster PDE test suite.
Comment 8 David Samuelsson CLA 2010-07-22 02:12:26 EDT
i updated this morning to the new buckminster version:

Buckminster - Core	1.3.1.r11513

I still get the same problem. Was the fix included in that release?
Comment 9 Thomas Hallgren CLA 2010-07-22 03:58:12 EDT
The fix is in the o.e.b.pde, revisions 11507 or higher. Did you start with a fresh workspace?
Comment 10 David Samuelsson CLA 2010-07-22 04:52:51 EDT
using:   Buckminster - PDE support	1.2.1.r11512	

same problem in new workspace. Same errors as described in bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=320345

Do you need anything more from me?