Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319302 - [nls tooling] Properties File Editor ignores "insert spaces for tabs"
Summary: [nls tooling] Properties File Editor ignores "insert spaces for tabs"
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-08 14:25 EDT by Matt CLA
Modified: 2010-08-06 04:32 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt CLA 2010-07-08 14:25:20 EDT 
Build Identifier: 20100218-1602

The Property Files Editor has some options set in Preferences | Java | Property Files Editor and also has some that it inherits from Preferences | General | Editors | Text Editors. The option to "Insert spaces for tabs" should be one of the second sort, however it seems to be ignored by the Editor.

Reproducible: Always

Steps to Reproduce:
1.In Preferences | General | Editors | Text Editors turn on "Insert spaces for tabs" and "Show whitespace character".
2.Create a file that is opened with the Property Files Editor (you may need to assign a file type to be opened with the PFE under the Preferences | General | Editor | File Associations.
3.Enter some tabs and notice that the PFE still uses tabs in the file that you have opened.
Comment 1 Prakash Rangaraj CLA 2010-07-29 04:40:41 EDT 
Moving to JDT UI
Comment 2 Dani Megert CLA 2010-07-29 04:46:34 EDT 
> Prakash G.R.      2010-07-29 10:40:41 CEST
>Moving to JDT UI

The bug was filed 2010-07-08. Would it be possible to redirect bugs to the right component a bit faster? ;-)

Thanks.
Comment 3 Dani Megert CLA 2010-07-29 04:48:40 EDT 
Mmh. Let me do some real work for a change ;-)
Comment 4 Dani Megert CLA 2010-07-29 05:05:37 EDT 
Fixed in PropertiesFileEditor.java rev. 1.26.
Available in builds > N20100728-2000.
Comment 5 Matt CLA 2010-07-30 09:52:28 EDT 
Thanks for fixing this!
Comment 6 Dani Megert CLA 2010-08-05 03:20:33 EDT 
Verified in I20100804-1800: the open editor did not update when the preference got changed. Fixed this now in HEAD.
Comment 7 Markus Keller CLA 2010-08-05 05:59:59 EDT 
(In reply to comment #6)
> Verified in I20100804-1800: the open editor did not update when the preference
> got changed. Fixed this now in HEAD.

I think the change in PropertiesFileEditor leaks the IPropertyChangeListener.
Comment 8 Dani Megert CLA 2010-08-05 09:07:54 EDT 
>I think the change in PropertiesFileEditor leaks the IPropertyChangeListener.
Indeed!

Fixed in HEAD.
I also added some leak tests for that to JavaLeakTest).
Comment 9 Dani Megert CLA 2010-08-06 04:32:39 EDT 
Verified in I20100805-1700.