Comment 1 David Carver 2010-07-08 14:23:08 EDT

Hmm...we'll see what we can do to track this down.  If we come up with a fix we'll try and back port as well to 3.2.2 maintenance release.

Adding Jesper on this as well.

Comment 2 David Carver 2010-07-09 16:52:20 EDT

Created attachment 173920 [details]
Proposed patch to help reduce number of times Image is created

The following is a slight refactoring of the code that retrieves the image to be displayed during content assistance, outline view, and xpath views.

This tries to reduce the number of times the image is created, and tries to reuse the same image if possible.  This also cleans the code up a bit and reduces some repetition.

Comment 3 Petrus Bergman 2010-07-10 22:10:35 EDT

(In reply to comment #2)

I downloaded the source and compiled a new jar with the patch to test it. However, I still see an increase of the allocated GDI objects when I type something in the XSL editor.

Comment 4 David Carver 2010-07-12 08:10:38 EDT

I think we need to apply a similar fix from bug 319226 to wst.xsl as well.

Comment 5 David Carver 2010-07-12 08:27:14 EDT

(In reply to comment #4)
> I think we need to apply a similar fix from bug 319226 to wst.xsl as well.

Petrus, please try getting the latest wst.xml.ui, wst.xml.core, wst.sse.ui, and wst.sse.core code out as well, and see if the patch in bug 319226 improves anything for you. (this should already be applied).

The reason you may see an increase in the leakage in the GDI is due to the image leaks that were occuring in the CMImageUtil class for xml.ui.   If from the XML Perspective you close both the Outline View and the XPath View, does the image leak continue?

These two views make use of the CMImageUtil to help return the image that should appear on the nodes, and everytime you type or press a key, these views are updated.

Comment 6 Michael Heß 2010-07-16 08:01:15 EDT

I am seeing this as well. Tough I could not have pinpointed it that exactly. :-/

What I am experiencing is, that for the last 2 days I had to work with XSL/XSD files. And ever since this type of work started, I have Helios crashing.

I have the logs from the workspace, including the stacks which were written to the log. I will attach them - maybe someone get something useful out of them.

Comment 7 Michael Heß 2010-07-16 08:01:52 EDT

Created attachment 174481 [details]
log of my workspace after helios crashed

Comment 8 Michael Heß 2010-07-16 08:02:08 EDT

Created attachment 174482 [details]
log 2 of my workspace after helios crashed

Comment 9 David Carver 2010-07-16 08:40:05 EDT

http://build.eclipse.org/webtools/committers/wtp-R3.2.1-M/20100715212701/M-3.2.1-20100715212701/

You may want to try using the 3.2.1 maintenance release Integration build to help determine if the patch for the prior bug mentioned fixes this issue.

Comment 10 Sam Bernet 2010-08-19 08:36:14 EDT

(In reply to comment #9)
> http://build.eclipse.org/webtools/committers/wtp-R3.2.1-M/20100715212701/M-3.2.1-20100715212701/

Hi,

Above link seems to be outdated, so I did only install the current version of the XSL Dev Tools:

Eclipse XSL Developer Tools	1.1.1.v201007132152-7S7WFANFIpS-0-NXEE5pifZBQLO

Should I try something else?

Comment 11 Sam Bernet 2010-08-19 08:42:01 EDT

(In reply to comment #10)

> Above link seems to be outdated, so I did only install the current version of
> the XSL Dev Tools:
> 
> Eclipse XSL Developer Tools    1.1.1.v201007132152-7S7WFANFIpS-0-NXEE5pifZBQLO

Which does not have any impact, I forgot to mention.

Comment 12 Sam Bernet 2010-08-19 08:54:36 EDT

A few more interesting observations:

1) If I close the Outline and XPath View in the XML perspective, then restart Eclipse and edit XSL files, the leak does NOT occur.

2) If either one or both (Outline, XPath View) are open, the leak does occur. Handles are of course leaked faster if both are visible.

3) If XPath View is open but Outline is closed, and XPath View contains an expression that does not yield any results for the current XSL, the leak does NOT occur. Only if the view actually lists result nodes/trees handles start to leak again.

4) Once one of these views is opened and leaking started, closing the view does NOT solve the problem. Leakage goes on until *BANG*.

5) It's not limited to XML Perspective. If Outline view is fully collapsed, (e.g. only root element is visible), about 3 handles per key-stroke are leaked. If I expand the list on a larger XSL, it leaks some dozens of handles per key-stroke. Again, once opened, leakage continues after closing Outline.

btw: I'm on Win XP SP2 32-bit, Eclipse Platform 3.6.0.I20100608-0911, Eclipse XML Editors and Tools 3.2.1.v201007132152-7H7AFUMDxumQGOh8tejUU2Uw_Mx0

Comment 13 David Carver 2010-08-19 09:23:43 EDT

Yeah, I suspect this will happen, due to the fact that the XPath View and Outline View use much of the same code for rendering the images.   Have you tried installing Webtools 3.2.1.  It should contain a fix for some of these image leaks:

http://download.eclipse.org/webtools/downloads/

An update site with the latest changes should be available at:

http://download.eclipse.org/webtools/repository/helios/



(In reply to comment #12)
> A few more interesting observations:
> 
> 1) If I close the Outline and XPath View in the XML perspective, then restart
> Eclipse and edit XSL files, the leak does NOT occur.
> 
> 2) If either one or both (Outline, XPath View) are open, the leak does occur.
> Handles are of course leaked faster if both are visible.
> 
> 3) If XPath View is open but Outline is closed, and XPath View contains an
> expression that does not yield any results for the current XSL, the leak does
> NOT occur. Only if the view actually lists result nodes/trees handles start to
> leak again.
> 
> 4) Once one of these views is opened and leaking started, closing the view does
> NOT solve the problem. Leakage goes on until *BANG*.
> 
> 5) It's not limited to XML Perspective. If Outline view is fully collapsed,
> (e.g. only root element is visible), about 3 handles per key-stroke are leaked.
> If I expand the list on a larger XSL, it leaks some dozens of handles per
> key-stroke. Again, once opened, leakage continues after closing Outline.
> 
> btw: I'm on Win XP SP2 32-bit, Eclipse Platform 3.6.0.I20100608-0911, Eclipse
> XML Editors and Tools 3.2.1.v201007132152-7H7AFUMDxumQGOh8tejUU2Uw_Mx0

Comment 14 David Carver 2010-08-19 09:34:00 EDT

Nick you fixed a similar issue recently in XML, mind taking a peak at the XSL code to see if you can locate the cause, or should this be fixed by the change that went into 3.2.1?

Comment 15 Sam Bernet 2010-08-19 10:32:52 EDT

I can confirm 3.2.1 does NOT fix or improve the issue. It takes me about one minute of writing nonsense to have eclipse freeze.

Comment 16 Nick Sandonato 2010-08-19 11:37:15 EDT

Created attachment 177016 [details]
image leak in JFaceNodeAdapter

Looks like the JFaceNodeAdapter was creating an unmanaged image quite frequently. For example, if you're in the <xsl:template> tag and you start typing freely, the outline view is being refreshed frequently, and you're creating a lot of images.

Comment 17 Nick Sandonato 2010-08-19 11:38:06 EDT

(In reply to comment #15)
> I can confirm 3.2.1 does NOT fix or improve the issue. It takes me about one
> minute of writing nonsense to have eclipse freeze.

Sam is right. My fix did not address this in 3.2.1 for XSL.

Comment 18 Jesper Moller 2010-08-19 16:58:24 EDT

(In reply to comment #17)
> (In reply to comment #15)
> > I can confirm 3.2.1 does NOT fix or improve the issue. It takes me about one
> > minute of writing nonsense to have eclipse freeze.
> 
> Sam is right. My fix did not address this in 3.2.1 for XSL.

We should be able to fix this for 3.2.2. Nick, does your latest patch fix the issue?

Comment 19 Nick Sandonato 2010-08-20 14:00:47 EDT

(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #15)
> > > I can confirm 3.2.1 does NOT fix or improve the issue. It takes me about one
> > > minute of writing nonsense to have eclipse freeze.
> > 
> > Sam is right. My fix did not address this in 3.2.1 for XSL.
> 
> We should be able to fix this for 3.2.2. Nick, does your latest patch fix the
> issue?

As far as I could tell, yes. I switched to the XML perspective and started typing text content in the xsl:template element. Without the patch, I saw the GDI Object count increase while typing. With the patch, the number stayed constant. This should address the specific scenario that Sam discusses.

Comment 20 David Carver 2010-08-21 19:30:52 EDT

Thanks for the patch Nick.  I've released this into both HEAD and the R3_2_maintenance branch.   R3_2_maintenance fix is tracked up bug 323316.