Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319189 - Metadata for graphicImage tries to resolve too many attributes
Summary: Metadata for graphicImage tries to resolve too many attributes
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: UI (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Ian Trimble CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 16:13 EDT by Ian Trimble CLA
Modified: 2010-08-27 14:39 EDT (History)
1 user (show)

See Also:
raghunathan.srinivasan: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: pmc_approved+
raghunathan.srinivasan: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Trimble CLA 2010-07-07 16:13:05 EDT 
The DTInfo model allows only zero or one "resolve-attribute-value" elements,
but three are defined in the metadata for graphicImage, and it seems the last
one defined is what is used in the runtime model. Unfortunately, the last one
defined is trying to resolve a "url" attribute on the result "img" tag - it
needs to resolve a "src" attribute. The other two elements ("value" and "url")
are unnecessary and need to be removed.
Comment 1 Raghunathan Srinivasan CLA 2010-08-24 15:50:25 EDT 
What is the impact to the end-user?
Comment 2 Ian Trimble CLA 2010-08-24 16:06:53 EDT 
(In reply to comment #1)
> What is the impact to the end-user?

Images URLs are not resolved and the image is not displayed.
Comment 3 Ian Trimble CLA 2010-08-25 20:02:44 EDT 
Fix checked in at 2010/08/25 05:02PM PDT.
Comment 4 Raghunathan Srinivasan CLA 2010-08-27 14:38:59 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
See comment 2
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
None
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual
* Give a brief technical overview. Who has reviewed this fix? 
See description
* What is the risk associated with this fix? 
none-low
Comment 5 Raghunathan Srinivasan CLA 2010-08-27 14:39:24 EDT 
This failed to make this week's build because of spurious junit failures in local testing.