Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319171 - SDO: HelperContext cache should not be keyed on HelperContextMapKey
Summary: SDO: HelperContext cache should not be keyed on HelperContextMapKey
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 14:17 EDT by David McCann CLA
Modified: 2022-06-09 10:35 EDT (History)
0 users

See Also:

Attachments
Contains proposed fix (27.23 KB, patch)
2010-07-07 15:14 EDT, David McCann CLA 		no flags Details | Diff
Contains proposed fix (27.63 KB, patch)
2010-07-08 14:10 EDT, David McCann CLA 		no flags Details | Diff
Contains proposed fix (27.68 KB, patch)
2010-07-09 10:54 EDT, David McCann CLA 		no flags Details | Diff
Contains proposed fix for 2.2 stream (38.09 KB, patch)
2010-07-16 14:43 EDT, David McCann CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McCann CLA 2010-07-07 14:17:03 EDT 
We should not be using the HelperContextMapKey class as the key to the helper context map.  This is due the the fact that we cannot get a unique hashcode, as we could have an application name alone, or an application name and a classloader.  We must support scenarios where the a given context is cached on application name and classloader, such that if a lookup is performed with the same loader in a non-WLS owned thread we can still return the correct helper context.
Comment 1 David McCann CLA 2010-07-07 15:14:47 EDT 
Created attachment 173700 [details]
Contains proposed fix
Comment 2 David McCann CLA 2010-07-08 14:10:46 EDT 
Created attachment 173799 [details]
Contains proposed fix
Comment 3 David McCann CLA 2010-07-09 10:54:38 EDT 
Created attachment 173870 [details]
Contains proposed fix
Comment 4 David McCann CLA 2010-07-16 14:43:42 EDT 
Created attachment 174528 [details]
Contains proposed fix for 2.2 stream
Comment 5 David McCann CLA 2010-07-16 14:53:42 EDT 
Fix checked into the 2.2 stream.
Reviewed by:  matt.macivor@oracle.com
Tests: all unit tests pass as expected; sdo server tests all pass
Comment 6 David McCann CLA 2010-07-16 15:02:12 EDT 
Fix for bugs 320035 (SDO: JBoss redeploy scenario not handled correctly in SDOHelperContext) and 319171 (SDO: HelperContext cache should not be keyed on HelperContextMapKey)
Reviewed by:  matt.macivor@oracle.com
Tests: all unit tests pass as expected
Comment 7 Eclipse Webmaster CLA 2022-06-09 10:35:33 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink