Community
Participate
Working Groups
The following patch adds actions to the RDT editor to make it consistent with the CDT editor. This allows debuggers to contribute breakpoint actions to the editor. The patch adds two dependencies: org.eclipse.debug.ui and org.eclipse.cdt.debug.ui. Please let me know if this is ok and I'll commit to 4.0 and HEAD.
Created attachment 173692 [details] patch to add debug actions
Hmmm... I know we had problems with the CDT breakpoint functionality consistently failing on the remote editor because it does an explicit instanceof check to see if it's the CDT local editor. So even with this, you might not get what you want. The one thing to check is that we can still properly contribute support for other debuggers without things still conflicting. Vivian can you try this out and see if there any conflicts with our debugger?
Is this ok to commit?
I tried applying this patch to my ptp_4_0 workspace, and it complained: Description Resource Path Location Type Unsatisfied version constraint: 'org.eclipse.debug.ui: 3.7.0' MANIFEST.MF org.eclipse.ptp.rdt.ui/META-INF line 39 Plug-in Problem Does it really require that version of debug.ui? There are some API changes that happened on CDT HEAD recently, so we don't have a working RDT right now on HEAD for me to test.
No that constraint is not required. I guess it was automatically added.
Created attachment 177376 [details] updated patch
I haven't been able to try out the patch, but I think it will be ok. It might cause some unwanted actions to show up in our IBM product, but we should be able to hide those using capabilities.
Applied to 4.0 and HEAD.
