Community
Participate
Working Groups
Build Identifier: The GDBControl_7_0.startOrRestart runs a sequence of steps. One of this steps determines whether to use -exec-run or -exec-continue, and stores a command in a member variable. A later step then queues the command. However, there's no reason to use a step to construct a command -- this is not an operation that takes a noticeable time, so using a step is likely to only add code size and some runtime overhead. The attached patch moves this logic into the step that actually runs the command. Reproducible: Always
Created attachment 173681 [details] The proposed patch
Thanks. I committed to HEAD with a extra change for an unnecessary 'global' variable.
*** cdt cvs genie on behalf of mkhouzam *** Bug 319165: Unnecessary step in GDBControl_7_0.startOrRestart [*] GDBControl_7_0.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/command/GDBControl_7_0.java?root=Tools_Project&r1=1.18&r2=1.19