Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319146 - Refactoring of DefaultTextEditComposer
Summary: Refactoring of DefaultTextEditComposer
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 11:26 EDT by Johan Wannheden CLA
Modified: 2017-09-19 16:29 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: helios+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Wannheden CLA 2010-07-07 11:26:45 EDT 
Build Identifier: 20100218-1602

The implementation of org.eclipse.xtext.ui.editor.model.edit.DefaultTextEditComposer.getObjectEdits() is a private method that does not allow to set the SaveOptions when serializing. In order to use custom SaveOptions, it is required to overwrite getTextExit() by providing an own TextEditComposer and to delegate to a custom getObjectEdits() method.

getObjectEdits() should not be private in order to make the class more easily extendable.

Reproducible: Always
Comment 1 Sebastian Zarnekow CLA 2010-08-24 08:48:21 EDT 
Fixed in HEAD.
Comment 2 Karsten Thoms CLA 2017-09-19 16:29:16 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.