Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319115 - [Compatibility] Double Ctrl+O is not working
Summary: [Compatibility] Double Ctrl+O is not working
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Remy Suen CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 08:15 EDT by Remy Suen CLA
Modified: 2010-07-07 12:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-07-07 08:15:26 EDT 
It appears to have been a problem since at least RC1. It works in my original workspace but not if I spawn a new one. It is broken in the inner also.
Comment 1 Remy Suen CLA 2010-07-07 08:49:33 EDT 
AbstractInformationControl's getInvokingCommandKeySequences() is returning 'null' for some reasons. JDT cannot do a keybinding comparison (to determine whether it is a request to show inherited members) so the second Ctrl+O becomes a no-op.
Comment 2 Remy Suen CLA 2010-07-07 11:05:30 EDT 
It seems we are never updating the ContextManager's active contexts. That seems to only ever be called when you request the active context ids from the EContextService.

Paul, are we not calling this method often enough or are we supposed to be updating the manager when contexts are activated/deactivated?
Comment 3 Paul Webster CLA 2010-07-07 11:10:32 EDT 
Does this mean we're asking the wrong guy for an active binding?  We're still depending on the legacy BindingService (strange that it used to work at all)?

PW
Comment 4 Remy Suen CLA 2010-07-07 12:01:34 EDT 
We have fixed this problem by altering the way CommandLegacyWrapper tries to query for its keybinding.