Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319108 - inconsistent models after #copyBean in MasterDetailsRidget with ToggleButtonRidget in details area
Summary: inconsistent models after #copyBean in MasterDetailsRidget with ToggleButtonR...
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: ridget (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 3.0.0.M4   Edit
Assignee: Elias Volanakis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 303179
  Show dependency tree
 
Reported: 2010-07-07 07:35 EDT by Holger Hoch CLA
Modified: 2010-12-14 09:19 EST (History)
2 users (show)

See Also:

Attachments
java class to reproduce bug (6.51 KB, application/octet-stream)
2010-07-07 07:38 EDT, Holger Hoch CLA 		no flags Details
Snippet to reproduce issue (6.81 KB, text/plain)
2010-07-15 19:22 EDT, Elias Volanakis CLA 		no flags Details
Fix (55.88 KB, patch)
2010-12-08 21:13 EST, Elias Volanakis CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoch CLA 2010-07-07 07:35:59 EDT 
Build Identifier: 2.0.0

If using a ToggleButtonRidget within the details area of a MasterDetailsRidget that is configured to use direct writing the delegates #copyBean method is called *before* the model of the ToggleButtonRidget resulting in inconsistent models

Reproducible: Always

Steps to Reproduce:
start attached code and click checkbox a few times
Comment 1 Holger Hoch CLA 2010-07-07 07:38:18 EDT 
Created attachment 173637 [details]
java class to reproduce bug
Comment 2 Elias Volanakis CLA 2010-07-15 19:04:14 EDT 
Reproducible. 

This is a conceptual issue with the ridgets embedded in the details area. The order how listeners are notified is not guaranteed, so  the master details ridget may look at the model before it is actually changed. For text ridgets I've added the "textAfter" property but I think we need a permanent fix or a new official event (like "afterUpdate").

Offer to look at this in the next sprint.
Comment 3 Elias Volanakis CLA 2010-07-15 19:22:54 EDT 
Created attachment 174461 [details]
Snippet to reproduce issue

Slightly modified snippet (tracing code, apply button)
Comment 4 Elias Volanakis CLA 2010-12-08 21:13:39 EST 
Created attachment 184830 [details]
Fix

The attached patch fixes all occurrences of this issue (in ToggleButtonRidget and elsewhere). Attaching for reference purposes.
Comment 5 Elias Volanakis CLA 2010-12-08 21:17:44 EST 
Resolved in HEAD.