Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319101 - OrderedServiceHooksExecuter not passing extension order correctly
Summary: OrderedServiceHooksExecuter not passing extension order correctly
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: communication (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0.M2   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 06:40 EDT by Patrick He CLA
Modified: 2010-10-29 06:20 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick He CLA 2010-07-07 06:40:06 EDT
Build Identifier: 20100617-1415

in OrderedServiceHooksExecuter, update() method, where the code is:
Orderer<IServiceHook> orderer = new Orderer<IServiceHook>();
		for (IServiceHookExtension extension : serviceHookExtensions) {
			orderer.add(extension.getServiceHook(), extension.getName(), extension.getPostHooks(), extension
					.getPostHooks());
		}

The getPostHooks() method is called twice but getPreHooks() is never called.

Not sure if there is any unit tests around this service ordering...

Reproducible: Always
Comment 1 Nobody - feel free to take it CLA 2010-07-15 09:21:00 EDT
Hello Patrick,
here we have to deal with even 2 bugs. 

1)What you describe: The construction of the Ordered-Object is not done right as the list of postHooks is used 2 times. preHooks just get igonred. 

2)I had a look at the implementation of afterCall. The delegation was wrong,too. I fixed it to delegate to sHook.afterCall(context);

Furthermore I added a the test OrderedCallHooksExecutorTest. Have a look at it if you like.