Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319080 - MarkerUpdaterImpl.UpdateMarker not cancel() friendly
Summary: MarkerUpdaterImpl.UpdateMarker not cancel() friendly
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 03:51 EDT by Stephane Barbey CLA
Modified: 2017-09-19 16:34 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: helios+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephane Barbey CLA 2010-07-07 03:51:47 EDT 
Shouldn't the for (Delta delta : resourceDescriptionDeltas) { ... } loop in org.eclipse.xtext.builder.builderState.MarkerUpdaterImpl.updateMarker(ResourceSet, ImmutableList<Delta>, IProgressMonitor) break when the monitor is canceled()?

There can be a large amount of deltas and addMarkers can be an expensive operation.

-Stephane
Comment 1 Sebastian Zarnekow CLA 2010-08-02 09:20:09 EDT 
Fixed in HEAD.
Comment 2 Karsten Thoms CLA 2017-09-19 16:34:54 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.