Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319059 - [NLS] Problems reported directly by JSP translation aren't externalized
Summary: [NLS] Problems reported directly by JSP translation aren't externalized
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard: PMC_approved WI49473
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 17:58 EDT by Nitin Dahyabhai CLA
Modified: 2010-07-08 15:36 EDT (History)
3 users (show)

See Also:
david_williams: pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan)
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
thatnitind: pmc_approved? (neil.hauge)
thatnitind: pmc_approved? (kaloyan)
nsand.dev: review+

Attachments
proposed patch, no new strings added (5.66 KB, patch)
2010-07-06 17:59 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2010-07-06 17:58:59 EDT 
JSP Java validation passes on JDT compiler messages, but also adds validation messages for server-side translation-time problems outside of Java source code.  These messages are not properly externalized.
Comment 1 Nitin Dahyabhai CLA 2010-07-06 17:59:29 EDT 
Created attachment 173604 [details]
proposed patch, no new strings added
Comment 2 Nick Sandonato CLA 2010-07-06 18:07:43 EDT 
Looks like a good fix to me.
Comment 3 Nitin Dahyabhai CLA 2010-07-06 18:22:13 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Untranslated strings are bad.  More than one of the generated problems doesn't even supply a message string in 3.2.0.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manually tested, breaks no existing BVT.

* Give a brief technical overview. Who has reviewed this fix? 

Changes reported strings to use existing externalized versions.

* What is the risk associated with this fix? 

Low.
Comment 4 David Williams CLA 2010-07-06 23:15:42 EDT 
Externalizing strings is important, so I think we should fix. How long have these been broken? Are these new validation messages? Can you think of any test to do in future to make sure these type of non-externalized strings don't sneak in? Maybe change project settings to flag as 'error'?
Comment 5 Nitin Dahyabhai CLA 2010-07-07 01:06:56 EDT 
(In reply to comment #4)
> Externalizing strings is important, so I think we should fix. How long have
> these been broken? Are these new validation messages? Can you think of any test
> to do in future to make sure these type of non-externalized strings don't sneak
> in? Maybe change project settings to flag as 'error'?

That may be the only way to be sure we catch them.  These have actually been around since 3.1 was in development, but validation messages being externalized aren't quite as trivial to verify as other elements of our UI.  The validation checks aren't new, and neither are the externalized messages we're using in this patch (no changes were made to a .properties file), they just weren't connected properly.
Comment 6 Nitin Dahyabhai CLA 2010-07-07 02:30:07 EDT 
Released to HEAD and maintenance.