Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319051 - Buttons in 'Manifest Entries' tab truncated for Russian
Summary: Buttons in 'Manifest Entries' tab truncated for Russian
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.common (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Carl Anderson CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 16:13 EDT by Aidyl Kareh CLA
Modified: 2010-07-08 15:34 EDT (History)
1 user (show)

See Also:
amkareh: pmc_approved? (david_williams)
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
deboer: pmc_approved+
amkareh: pmc_approved? (neil.hauge)
amkareh: pmc_approved? (kaloyan)
ccc: review+

Attachments
Proposed Patch (3.01 KB, patch)
2010-07-06 16:25 EDT, Aidyl Kareh CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-07-06 16:13:10 EDT 
Build Identifier: WTP 3.2

When you go to the 'Manifest Entries' tab in the 'Deployment Assembly' properties page (right click on project and select Properties->Deployment Assembly->Manifest Entries tab), the "Add" and "Delete" buttons are truncated with some translations.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-07-06 16:25:48 EDT 
Created attachment 173596 [details]
Proposed Patch

Problem was caused because the layout for the 'Manifest Entries' table was only based on the width of the 'Move Down' button. Patch solves the issue by adding a composite to hold all the buttons.
Comment 2 Carl Anderson CLA 2010-07-07 08:59:38 EDT 
I approve of this change.
Comment 3 Aidyl Kareh CLA 2010-07-07 10:12:02 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

The contents of the buttons in the 'Manifest Entries' tab of the 'Deployment Assembly' properties page are being truncated for some translations which impacts the user since they might not be able to tell what the function of the button is.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Tested through UI.

    * Give a brief technical overview. Who has reviewed this fix? 

Patch fixes layout problems by adding a composite to hold all the buttons. This solves the issue by now basing the width of the 'Manifest Entries' table on the width of the composite instead of on the width of a single button. Reviewed by Carl Anderson and Chuck Bridgham.

    * What is the risk associated with this fix? 
None.
Comment 4 Carl Anderson CLA 2010-07-07 11:36:28 EDT 
Committed to HEAD for WTP 3.2.1 and WTP 3.3