Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 319048 - Utility code may leak Image handles
Summary: Utility code may leak Image handles
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 3.0.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 15:50 EDT by Nick Sandonato CLA
Modified: 2010-07-09 17:12 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (3.49 KB, patch)
2010-07-06 16:11 EDT, Nick Sandonato CLA 		no flags Details | Diff
patch update (4.61 KB, patch)
2010-07-07 14:38 EDT, Nick Sandonato CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-07-06 15:50:48 EDT 
The CMImageUtility class has the potential to leak Image handles.

Calls to CMImageUtility#getImage() will retrieve a cached image descriptor, but will create a new Image from the descriptor every time. Each call with then result in one leaked Image handle.
Comment 1 Nick Sandonato CLA 2010-07-06 16:11:46 EDT 
Created attachment 173594 [details]
patch
Comment 2 Nick Sandonato CLA 2010-07-07 14:38:56 EDT 
Created attachment 173697 [details]
patch update

Updated the patch to utilize the ImageRegistry entirely.
Comment 3 Carl Anderson CLA 2010-07-09 17:12:28 EDT 
Committed to R3_0_5_patches