Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318903 - [UI] Search Bar and Perspective switcher should always be on the same line
Summary: [UI] Search Bar and Perspective switcher should always be on the same line
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 10:53 EDT by Eric Moffatt CLA
Modified: 2010-07-20 13:25 EDT (History)
0 users

See Also:

Attachments
Introduce a 'glue' layout modifier (10.32 KB, patch)
2010-07-05 11:03 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2010-07-05 10:53:26 EDT 
Right now if you resize the window it will first place the Perspetive Switcher onto the second line (where it is *not* left-aligned because the spacer control is still on the first line...).
Comment 1 Eric Moffatt CLA 2010-07-05 11:03:41 EDT 
Created attachment 173439 [details]
Introduce a 'glue' layout modifier


This patch augments the TrimBarLayout to understand a second modifier "glue" that will ensure that the TrimControls to either side of it appear on the same tiled line in the layout.

Note that the layout code is somewhat fragile at the moment in that it won't handle strange conditions such as multiple successive 'glue' modifiers or odd combinations of glue and spacers...
Comment 2 Eric Moffatt CLA 2010-07-05 11:05:21 EDT 
Committed in >20100705. Applied the patch. 

I'll mark this as fixed, we can open a separate defect if we end up in any of the unhandled corners...