Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318886 - Code Assist is not well sync'ed
Summary: Code Assist is not well sync'ed
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 08:19 EDT by Seva Lapsha CLA
Modified: 2020-05-14 10:16 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Seva Lapsha CLA 2010-07-05 08:19:55 EDT
Build Identifier: 2.2.0.v20100516-1300-7L7J-F8NcJRaL3Ph9SBPK

PHPCore plugin internal error

java.util.ConcurrentModificationException
	at java.util.LinkedList$ListItr.checkForComodification(Unknown Source)
	at java.util.LinkedList$ListItr.next(Unknown Source)
	at org.eclipse.php.internal.core.documentModel.parser.regions.PhpTokenContainer.getToken(PhpTokenContainer.java:71)
	at org.eclipse.php.internal.core.documentModel.parser.regions.PhpScriptRegion.getPhpToken(PhpScriptRegion.java:85)
	at org.eclipse.php.internal.core.util.text.PHPTextSequenceUtilities.getStatement(PHPTextSequenceUtilities.java:116)
	at org.eclipse.php.internal.core.codeassist.PHPSelectionEngine.internalResolve(PHPSelectionEngine.java:388)
	at org.eclipse.php.internal.core.codeassist.PHPSelectionEngine.select(PHPSelectionEngine.java:139)
	at org.eclipse.dltk.internal.core.Openable.codeSelect(Openable.java:578)
	at org.eclipse.dltk.internal.core.AbstractSourceModule.codeSelect(AbstractSourceModule.java:85)
	at org.eclipse.dltk.internal.core.AbstractSourceModule.codeSelect(AbstractSourceModule.java:76)
	at org.eclipse.php.internal.ui.editor.highlighters.InternalClassHighlighting.isInternalClass(InternalClassHighlighting.java:60)
	at org.eclipse.php.internal.ui.editor.highlighters.InternalClassHighlighting.access$0(InternalClassHighlighting.java:57)
	at org.eclipse.php.internal.ui.editor.highlighters.InternalClassHighlighting$InternalClassApply.visit(InternalClassHighlighting.java:29)
	at org.eclipse.php.internal.core.ast.nodes.Identifier.accept0(Identifier.java:66)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.Variable.childrenAccept(Variable.java:120)
	at org.eclipse.php.internal.core.ast.nodes.Variable.accept0(Variable.java:114)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.Assignment.childrenAccept(Assignment.java:129)
	at org.eclipse.php.internal.core.ast.nodes.Assignment.accept0(Assignment.java:159)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.ExpressionStatement.childrenAccept(ExpressionStatement.java:73)
	at org.eclipse.php.internal.core.ast.nodes.ExpressionStatement.accept0(ExpressionStatement.java:67)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.Block.childrenAccept(Block.java:97)
	at org.eclipse.php.internal.core.ast.nodes.Block.accept0(Block.java:90)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.FunctionDeclaration.childrenAccept(FunctionDeclaration.java:108)
	at org.eclipse.php.internal.core.ast.nodes.FunctionDeclaration.accept0(FunctionDeclaration.java:97)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.MethodDeclaration.childrenAccept(MethodDeclaration.java:90)
	at org.eclipse.php.internal.core.ast.nodes.MethodDeclaration.accept0(MethodDeclaration.java:82)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.Block.childrenAccept(Block.java:97)
	at org.eclipse.php.internal.core.ast.nodes.Block.accept0(Block.java:90)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.ClassDeclaration.childrenAccept(ClassDeclaration.java:118)
	at org.eclipse.php.internal.core.ast.nodes.ClassDeclaration.accept0(ClassDeclaration.java:104)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.core.ast.nodes.Program.childrenAccept(Program.java:195)
	at org.eclipse.php.internal.core.ast.nodes.Program.accept0(Program.java:188)
	at org.eclipse.php.internal.core.ast.nodes.ASTNode.accept(ASTNode.java:275)
	at org.eclipse.php.internal.ui.editor.highlighter.AbstractSemanticHighlighting.consumes(AbstractSemanticHighlighting.java:93)
	at org.eclipse.php.internal.ui.editor.highlighter.AbstractSemanticHighlighting.consumes(AbstractSemanticHighlighting.java:102)
	at org.eclipse.wst.sse.ui.internal.style.SemanticHighlightingReconciler.reconcile(SemanticHighlightingReconciler.java:127)
	at org.eclipse.wst.sse.ui.internal.reconcile.DocumentRegionProcessor.endProcessing(DocumentRegionProcessor.java:119)
	at org.eclipse.wst.sse.ui.internal.reconcile.DirtyRegionProcessor.run(DirtyRegionProcessor.java:682)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)


Reproducible: Always

Steps to Reproduce:
Whyle editing method signature
Comment 1 Roy Ganor CLA 2010-07-06 03:28:42 EDT
an example will be helpful, because IMO we already fixed this issue in head.
Comment 2 Seva Lapsha CLA 2010-07-06 04:15:39 EDT
I was just editing the code, and didn't request content assist implicitly. Unf'ly I didn't notice when it happened exactly. Sorry.

But I think it should be easy to track the usages of PhpTokenContainer to identify the problem.
Comment 3 Zhongwei Zhao CLA 2010-07-06 21:55:22 EDT
Hi Seva

It seems like multi thread issue,so it will be very helpful if there are some steps to reproduce this bug,thanks!
Comment 4 Zhongwei Zhao CLA 2010-07-12 03:31:45 EDT
Is this the same as Bug 318882?
Comment 5 Seva Lapsha CLA 2010-07-12 06:28:08 EDT
(In reply to comment #4)
> Is this the same as Bug 318882?

No.
Comment 6 Zhongwei Zhao CLA 2010-07-12 06:37:27 EDT
btw,do I need edit the editor very very quickly?
Comment 7 Seva Lapsha CLA 2010-07-12 10:21:51 EDT
(In reply to comment #6)
> btw,do I need edit the editor very very quickly?
:)

I'm not sure, I type very quickly all the time. :) But I have a feeling it's less relevant in this case.
Comment 8 Zhongwei Zhao CLA 2010-07-13 05:27:17 EDT
fixed in head
Comment 9 Zhongwei Zhao CLA 2010-07-22 22:02:34 EDT
mark as fixed
Comment 10 Sylvia Tancheva CLA 2010-09-02 04:58:17 EDT
Tried typing as fast as I can - did not get any errors.
Closing the bug.
Seva, if you can still get this error, please help me with more info for reproduction (and reopen of course). Thanks.