Community
Participate
Working Groups
I20100701-1105. 1. start with new workspace ==> the toolbar has many empty groups ==> many useless separators As per bugzilla terms this is 'normal' severity but marking as 'major' because this gives a very bad first impression of Eclipse 4.0.
Created attachment 173712 [details] screenshot on win7, Build id: I20100706-2130 adding screenshot since I had it for another bug
See bug 318850 comment 2: "This also gets rid of the many extra separators in the toolbar." However, that fix now removes too many: some groups (e.g. Debug and JDT UI) are no longer separated in the toolbar.
I attempted a fix yesterday but it looks like I need your help, Eric. I'd like to add a separator toolbar item at the beginning of each non-empty MToolBar.
>However, that fix now removes too many: some groups (e.g. Debug and JDT UI) are >no longer separated in the toolbar. I've adjusted the summary.
Created attachment 174253 [details] fix idea 1 Just to capture this code because it works in theory and might be useful somewhere else. Unfortunately it doesn't work in practice ;-)
Created attachment 174254 [details] fix idea 2 Another idea that didn't work (using an addon to change the toBeRendered flag in the model based on whether the toolbar contains items that are not just separators). Leads to an endless loop of toolbars appearing and disappearing,
Created attachment 174255 [details] refactoring of fixZOrder This belongs to fix idea 1. I had to move the fixZOrder logic to the renderer in order to add separator widgets between the actual children widgets. These changes are now no longer necessary but may be interesting should the need for rendering separator widgets arise somewhere else.
Created attachment 174256 [details] close to what I want This patch is going in the right direction but isn't pixel perfect yet. I hope to achieve pixel-perfectness tomorrow.
Created attachment 174257 [details] screenshot when running with "close to what I want" patch As you can see in this screenshot, there's too much space between the separator and the next toolbar item to the right.
Created attachment 174341 [details] fix Looks like it's working now.
last patch ("fix") committed to HEAD.
Verified in SDK 4.0 - I20100718-2237.
