318802 – UIMessages should extend NLS class

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318802 - UIMessages should extend NLS class

Summary: UIMessages should extend NLS class

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-core (show other bugs)
Version:	7.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Andrew Gvozdev
QA Contact:	Doug Schaefer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	316766
	Show dependency tree

Reported:	2010-07-03 23:15 EDT by Andrew Gvozdev
Modified:	2011-05-12 16:50 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
patch (190.64 KB, patch) 2010-07-04 01:06 EDT, Andrew Gvozdev	cdtdoug: iplog-	Details \| Diff
7.0.1 patch (190.63 KB, patch) 2010-07-04 01:56 EDT, Andrew Gvozdev	cdtdoug: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Gvozdev

2010-07-03 23:15:51 EDT

I still want to fix UIMessages since I run into it a lot.

Here is a test that should work after the changes:
0. Find a reference to one of the variables in UIMessages class, for example UIMessages.AbstractLangsListTab_2 in (AbstractLangsListTab.java:105) .
1. Hover the mouse pointer over it. You should see the message it points to: "Export".
2. Hold Ctrl and then hover mouse pointer. You should get suggestion to open in message.properties. On click it navigates to the definition in the file.
3. In message.properties, position the cursor on AbstractLangsListTab_2. Press F3. It should open a list of occurrences in the code (or directly jump there if only one occurence)
4. In message.properties, position the cursor on AbstractLangsListTab_2. Ctrl-[mouse click] should work the same as F3.

Comment 1 CDT Genie

2010-07-04 00:23:02 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318802: UIMessages should extend NLS class
PluginResources.properties renamed to Messages.properties

[+] Messages.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/Messages.properties?root=Tools_Project&revision=1.1&view=markup

Comment 2 Andrew Gvozdev

2010-07-04 01:06:54 EDT

Created attachment 173366 [details]
patch

Quite a bit of changes so I attach a patch just in case.

Comment 3 Andrew Gvozdev

2010-07-04 01:10:24 EDT

(In reply to comment #1)
> *** cdt cvs genie on behalf of agvozdev ***
> bug 318802: UIMessages should extend NLS class
> PluginResources.properties renamed to Messages.properties
> [+] Messages.properties
http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/Messages.properties?root=Tools_Project&revision=1.1&view=markup
Forget this file, I put it into internal package.

Comment 4 CDT Genie

2010-07-04 01:23:02 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318802: UIMessages should extend NLS class

[-] Messages.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/Messages.properties?root=Tools_Project&view=markup

[*] FileListControl.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/FileListControl.java?root=Tools_Project&r1=1.13&r2=1.14

[*] BuildJob.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/workingsets/BuildJob.java?root=Tools_Project&r1=1.1&r2=1.2

[*] CProjectWizard.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CProjectWizard.java?root=Tools_Project&r1=1.18&r2=1.19
[*] CDTMainWizardPage.java 1.32 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTMainWizardPage.java?root=Tools_Project&r1=1.31&r2=1.32
[*] CCProjectWizard.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CCProjectWizard.java?root=Tools_Project&r1=1.11&r2=1.12
[*] CDTProjectWizard.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTProjectWizard.java?root=Tools_Project&r1=1.3&r2=1.4
[*] CDTCommonProjectWizard.java 1.31 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTCommonProjectWizard.java?root=Tools_Project&r1=1.30&r2=1.31

[+] Messages.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.properties?root=Tools_Project&revision=1.1&view=markup
[+] Messages.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.java?root=Tools_Project&revision=1.1&view=markup

[*] BinaryParsTab.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BinaryParsTab.java?root=Tools_Project&r1=1.18&r2=1.19
[*] EnvironmentTab.java 1.27 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java?root=Tools_Project&r1=1.26&r2=1.27
[*] CDTPrefUtil.java 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPrefUtil.java?root=Tools_Project&r1=1.23&r2=1.24
[*] ProjectContentsArea.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ProjectContentsArea.java?root=Tools_Project&r1=1.4&r2=1.5
[*] CLocationOutputTab.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationOutputTab.java?root=Tools_Project&r1=1.5&r2=1.6
[*] MultiLineTextFieldEditor.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/MultiLineTextFieldEditor.java?root=Tools_Project&r1=1.5&r2=1.6
[*] CLocationSourceTab.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationSourceTab.java?root=Tools_Project&r1=1.5&r2=1.6
[*] ErrorParsTab.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ErrorParsTab.java?root=Tools_Project&r1=1.17&r2=1.18
[*] AbstractExportTab.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractExportTab.java?root=Tools_Project&r1=1.18&r2=1.19
[*] NewConfigurationDialog.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/NewConfigurationDialog.java?root=Tools_Project&r1=1.6&r2=1.7
[*] AbstractPage.java 1.78 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractPage.java?root=Tools_Project&r1=1.77&r2=1.78
[*] ExpDialog.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ExpDialog.java?root=Tools_Project&r1=1.9&r2=1.10
[*] AbstractLangsListTab.java 1.44 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractLangsListTab.java?root=Tools_Project&r1=1.43&r2=1.44
[*] IncludeTab.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeTab.java?root=Tools_Project&r1=1.11&r2=1.12
[*] EnvDialog.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvDialog.java?root=Tools_Project&r1=1.8&r2=1.9
[*] ConfigMultiSelectionDialog.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ConfigMultiSelectionDialog.java?root=Tools_Project&r1=1.7&r2=1.8
[*] IncludeFileTab.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeFileTab.java?root=Tools_Project&r1=1.1&r2=1.2
[*] UIMessages.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/UIMessages.java?root=Tools_Project&r1=1.6&r2=1.7
[*] CDTPropertyManager.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPropertyManager.java?root=Tools_Project&r1=1.8&r2=1.9
[*] LibraryPathTab.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryPathTab.java?root=Tools_Project&r1=1.10&r2=1.11
[*] RefsTab.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RefsTab.java?root=Tools_Project&r1=1.17&r2=1.18
[*] ManageConfigDialog.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigDialog.java?root=Tools_Project&r1=1.14&r2=1.15
[*] ManageConfigRunner.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigRunner.java?root=Tools_Project&r1=1.6&r2=1.7
[*] SymbolDialog.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolDialog.java?root=Tools_Project&r1=1.6&r2=1.7
[*] IncludeDialog.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeDialog.java?root=Tools_Project&r1=1.11&r2=1.12
[*] LibraryTab.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryTab.java?root=Tools_Project&r1=1.9&r2=1.10
[*] RenameConfigurationDialog.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RenameConfigurationDialog.java?root=Tools_Project&r1=1.5&r2=1.6
[-] PluginResources.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/PluginResources.properties?root=Tools_Project&view=markup
[*] BuildVarListDialog.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BuildVarListDialog.java?root=Tools_Project&r1=1.5&r2=1.6
[*] CLocationTab.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationTab.java?root=Tools_Project&r1=1.15&r2=1.16
[*] StructureTreeTab.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/StructureTreeTab.java?root=Tools_Project&r1=1.12&r2=1.13
[*] ImportExportWizardButtons.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ImportExportWizardButtons.java?root=Tools_Project&r1=1.2&r2=1.3
[*] AbstractCPropertyTab.java 1.40 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractCPropertyTab.java?root=Tools_Project&r1=1.39&r2=1.40
[*] SymbolTab.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolTab.java?root=Tools_Project&r1=1.16&r2=1.17

[*] ExcludeFromBuildHandler.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/ExcludeFromBuildHandler.java?root=Tools_Project&r1=1.1&r2=1.2

[*] MANIFEST.MF 1.57 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.56&r2=1.57

[*] ExcludeFromBuildAction.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/actions/ExcludeFromBuildAction.java?root=Tools_Project&r1=1.12&r2=1.13

Comment 5 Andrew Gvozdev

2010-07-04 01:56:03 EDT

Created attachment 173367 [details]
7.0.1 patch

Comment 6 Andrew Gvozdev

2010-07-04 01:57:43 EDT

Committed on HEAD (8.0) and 7.0.1

Comment 7 Andrew Gvozdev

2010-07-04 02:04:17 EDT

Need to look at its usage in managedbuilder plugins still.

Comment 8 CDT Genie

2010-07-04 02:23:03 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318802: UIMessages should extend NLS class

[*] FileListControl.java 1.13.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/FileListControl.java?root=Tools_Project&r1=1.13&r2=1.13.2.1

[*] CProjectWizard.java 1.18.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CProjectWizard.java?root=Tools_Project&r1=1.18&r2=1.18.2.1
[*] CDTMainWizardPage.java 1.31.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTMainWizardPage.java?root=Tools_Project&r1=1.31&r2=1.31.2.1
[*] CCProjectWizard.java 1.11.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CCProjectWizard.java?root=Tools_Project&r1=1.11&r2=1.11.2.1
[*] CDTProjectWizard.java 1.3.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTProjectWizard.java?root=Tools_Project&r1=1.3&r2=1.3.2.1
[*] CDTCommonProjectWizard.java 1.30.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTCommonProjectWizard.java?root=Tools_Project&r1=1.30&r2=1.30.2.1

[*] BuildJob.java 1.1.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/workingsets/BuildJob.java?root=Tools_Project&r1=1.1&r2=1.1.6.1

[*] MANIFEST.MF 1.53.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.53.2.1&r2=1.53.2.2

[+] Messages.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.properties?root=Tools_Project&revision=1.1&view=markup
[+] Messages.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.java?root=Tools_Project&revision=1.1&view=markup

[*] ExcludeFromBuildHandler.java 1.1.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/ExcludeFromBuildHandler.java?root=Tools_Project&r1=1.1.2.2&r2=1.1.2.3

[*] BinaryParsTab.java 1.18.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BinaryParsTab.java?root=Tools_Project&r1=1.18&r2=1.18.2.1
[*] EnvironmentTab.java 1.26.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java?root=Tools_Project&r1=1.26&r2=1.26.2.1
[*] CDTPrefUtil.java 1.23.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPrefUtil.java?root=Tools_Project&r1=1.23&r2=1.23.2.1
[*] ProjectContentsArea.java 1.4.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ProjectContentsArea.java?root=Tools_Project&r1=1.4&r2=1.4.6.1
[*] CLocationOutputTab.java 1.5.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationOutputTab.java?root=Tools_Project&r1=1.5&r2=1.5.6.1
[*] MultiLineTextFieldEditor.java 1.5.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/MultiLineTextFieldEditor.java?root=Tools_Project&r1=1.5&r2=1.5.6.1
[*] CLocationSourceTab.java 1.5.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationSourceTab.java?root=Tools_Project&r1=1.5&r2=1.5.6.1
[*] ErrorParsTab.java 1.17.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ErrorParsTab.java?root=Tools_Project&r1=1.17&r2=1.17.2.1
[*] AbstractExportTab.java 1.18.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractExportTab.java?root=Tools_Project&r1=1.18&r2=1.18.2.1
[*] NewConfigurationDialog.java 1.6.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/NewConfigurationDialog.java?root=Tools_Project&r1=1.6&r2=1.6.6.1
[*] AbstractPage.java 1.77.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractPage.java?root=Tools_Project&r1=1.77&r2=1.77.2.1
[*] ExpDialog.java 1.9.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ExpDialog.java?root=Tools_Project&r1=1.9&r2=1.9.6.1
[*] AbstractLangsListTab.java 1.42.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractLangsListTab.java?root=Tools_Project&r1=1.42.2.1&r2=1.42.2.2
[*] IncludeTab.java 1.11.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeTab.java?root=Tools_Project&r1=1.11&r2=1.11.2.1
[*] EnvDialog.java 1.8.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvDialog.java?root=Tools_Project&r1=1.8&r2=1.8.6.1
[*] ConfigMultiSelectionDialog.java 1.7.4.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ConfigMultiSelectionDialog.java?root=Tools_Project&r1=1.7&r2=1.7.4.1
[*] IncludeFileTab.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeFileTab.java?root=Tools_Project&r1=1.1&r2=1.1.2.1
[*] UIMessages.java 1.6.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/UIMessages.java?root=Tools_Project&r1=1.6&r2=1.6.2.1
[*] CDTPropertyManager.java 1.8.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPropertyManager.java?root=Tools_Project&r1=1.8&r2=1.8.6.1
[*] LibraryPathTab.java 1.10.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryPathTab.java?root=Tools_Project&r1=1.10&r2=1.10.6.1
[*] RefsTab.java 1.17.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RefsTab.java?root=Tools_Project&r1=1.17&r2=1.17.2.1
[*] ManageConfigDialog.java 1.14.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigDialog.java?root=Tools_Project&r1=1.14&r2=1.14.6.1
[*] ManageConfigRunner.java 1.6.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigRunner.java?root=Tools_Project&r1=1.6&r2=1.6.6.1
[*] SymbolDialog.java 1.6.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolDialog.java?root=Tools_Project&r1=1.6&r2=1.6.6.1
[*] IncludeDialog.java 1.11.4.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeDialog.java?root=Tools_Project&r1=1.11&r2=1.11.4.1
[*] LibraryTab.java 1.9.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryTab.java?root=Tools_Project&r1=1.9&r2=1.9.6.1
[*] RenameConfigurationDialog.java 1.5.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RenameConfigurationDialog.java?root=Tools_Project&r1=1.5&r2=1.5.6.1
[-] PluginResources.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/PluginResources.properties?root=Tools_Project&view=markup
[*] BuildVarListDialog.java 1.5.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BuildVarListDialog.java?root=Tools_Project&r1=1.5&r2=1.5.6.1
[*] CLocationTab.java 1.15.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationTab.java?root=Tools_Project&r1=1.15&r2=1.15.2.1
[*] StructureTreeTab.java 1.12.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/StructureTreeTab.java?root=Tools_Project&r1=1.12&r2=1.12.6.1
[*] ImportExportWizardButtons.java 1.2.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ImportExportWizardButtons.java?root=Tools_Project&r1=1.2&r2=1.2.2.1
[*] AbstractCPropertyTab.java 1.39.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractCPropertyTab.java?root=Tools_Project&r1=1.39&r2=1.39.2.1
[*] SymbolTab.java 1.16.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolTab.java?root=Tools_Project&r1=1.16&r2=1.16.2.1

[*] ExcludeFromBuildAction.java 1.10.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/actions/ExcludeFromBuildAction.java?root=Tools_Project&r1=1.10&r2=1.10.2.1

Comment 9 Andrew Gvozdev

2010-07-04 09:35:59 EDT

(In reply to comment #7)
> Need to look at its usage in managedbuilder plugins still.
Created bug 318812 for that.

Comment 10 CDT Genie

2010-07-06 00:23:02 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318802: UIMessages should extend NLS class
Removed unused variables

[*] Messages.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.java?root=Tools_Project&r1=1.1&r2=1.2

[*] Messages.java 1.1.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.java?root=Tools_Project&r1=1.1.2.2&r2=1.1.2.3

Comment 11 Vivian Kong

2010-09-14 10:41:01 EDT

Hi Andrew,

Sorry for not speaking up earlier but the changes you checked into 7.0.1 breaks any translation work done in CDT 7.0.  This is a major breakage.  Can we please revert this change in 7.0.1?

Comment 12 Andrew Gvozdev

2010-09-14 11:16:40 EDT

(In reply to comment #5)
> Created an attachment (id=173367)
> 7.0.1 patch
7.0.1 patch reverted on the branch.

Comment 13 CDT Genie

2010-09-14 11:23:07 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318802: Reverted as it broke translation work

[*] FileListControl.java 1.13.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/FileListControl.java?root=Tools_Project&r1=1.13.2.1&r2=1.13.2.2

[*] CProjectWizard.java 1.18.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CProjectWizard.java?root=Tools_Project&r1=1.18.2.1&r2=1.18.2.2
[*] CDTMainWizardPage.java 1.31.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTMainWizardPage.java?root=Tools_Project&r1=1.31.2.1&r2=1.31.2.2
[*] CCProjectWizard.java 1.11.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CCProjectWizard.java?root=Tools_Project&r1=1.11.2.1&r2=1.11.2.2
[*] CDTProjectWizard.java 1.3.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTProjectWizard.java?root=Tools_Project&r1=1.3.2.1&r2=1.3.2.2
[*] CDTCommonProjectWizard.java 1.30.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/CDTCommonProjectWizard.java?root=Tools_Project&r1=1.30.2.1&r2=1.30.2.2

[*] BinaryParsTab.java 1.18.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BinaryParsTab.java?root=Tools_Project&r1=1.18.2.1&r2=1.18.2.2
[*] EnvironmentTab.java 1.26.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java?root=Tools_Project&r1=1.26.2.1&r2=1.26.2.2
[*] CDTPrefUtil.java 1.23.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPrefUtil.java?root=Tools_Project&r1=1.23.2.1&r2=1.23.2.2
[*] ProjectContentsArea.java 1.4.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ProjectContentsArea.java?root=Tools_Project&r1=1.4.6.1&r2=1.4.6.2
[*] CLocationOutputTab.java 1.5.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationOutputTab.java?root=Tools_Project&r1=1.5.6.1&r2=1.5.6.2
[*] MultiLineTextFieldEditor.java 1.5.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/MultiLineTextFieldEditor.java?root=Tools_Project&r1=1.5.6.1&r2=1.5.6.2
[*] CLocationSourceTab.java 1.5.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationSourceTab.java?root=Tools_Project&r1=1.5.6.1&r2=1.5.6.2
[*] ErrorParsTab.java 1.17.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ErrorParsTab.java?root=Tools_Project&r1=1.17.2.1&r2=1.17.2.2
[*] AbstractExportTab.java 1.18.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractExportTab.java?root=Tools_Project&r1=1.18.2.1&r2=1.18.2.2
[*] NewConfigurationDialog.java 1.6.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/NewConfigurationDialog.java?root=Tools_Project&r1=1.6.6.1&r2=1.6.6.2
[*] AbstractPage.java 1.77.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractPage.java?root=Tools_Project&r1=1.77.2.2&r2=1.77.2.3
[*] ExpDialog.java 1.9.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ExpDialog.java?root=Tools_Project&r1=1.9.6.1&r2=1.9.6.2
[*] AbstractLangsListTab.java 1.42.2.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractLangsListTab.java?root=Tools_Project&r1=1.42.2.3&r2=1.42.2.4
[*] IncludeTab.java 1.11.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeTab.java?root=Tools_Project&r1=1.11.2.1&r2=1.11.2.2
[*] EnvDialog.java 1.8.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvDialog.java?root=Tools_Project&r1=1.8.6.1&r2=1.8.6.2
[*] ConfigMultiSelectionDialog.java 1.7.4.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ConfigMultiSelectionDialog.java?root=Tools_Project&r1=1.7.4.1&r2=1.7.4.2
[*] IncludeFileTab.java 1.1.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeFileTab.java?root=Tools_Project&r1=1.1.2.1&r2=1.1.2.2
[*] UIMessages.java 1.6.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/UIMessages.java?root=Tools_Project&r1=1.6.2.1&r2=1.6.2.2
[*] CDTPropertyManager.java 1.8.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CDTPropertyManager.java?root=Tools_Project&r1=1.8.6.1&r2=1.8.6.2
[*] LibraryPathTab.java 1.10.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryPathTab.java?root=Tools_Project&r1=1.10.6.1&r2=1.10.6.2
[*] RefsTab.java 1.17.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RefsTab.java?root=Tools_Project&r1=1.17.2.2&r2=1.17.2.3
[*] ManageConfigDialog.java 1.14.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigDialog.java?root=Tools_Project&r1=1.14.6.1&r2=1.14.6.2
[*] ManageConfigRunner.java 1.6.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ManageConfigRunner.java?root=Tools_Project&r1=1.6.6.1&r2=1.6.6.2
[*] SymbolDialog.java 1.6.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolDialog.java?root=Tools_Project&r1=1.6.6.1&r2=1.6.6.2
[*] IncludeDialog.java 1.11.4.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/IncludeDialog.java?root=Tools_Project&r1=1.11.4.1&r2=1.11.4.2
[*] LibraryTab.java 1.9.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/LibraryTab.java?root=Tools_Project&r1=1.9.6.1&r2=1.9.6.2
[*] RenameConfigurationDialog.java 1.5.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/RenameConfigurationDialog.java?root=Tools_Project&r1=1.5.6.1&r2=1.5.6.2
[+] PluginResources.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/PluginResources.properties?root=Tools_Project&revision=1.1&view=markup
[*] BuildVarListDialog.java 1.5.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/BuildVarListDialog.java?root=Tools_Project&r1=1.5.6.1&r2=1.5.6.2
[*] CLocationTab.java 1.15.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/CLocationTab.java?root=Tools_Project&r1=1.15.2.1&r2=1.15.2.2
[*] StructureTreeTab.java 1.12.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/StructureTreeTab.java?root=Tools_Project&r1=1.12.6.1&r2=1.12.6.2
[*] ImportExportWizardButtons.java 1.2.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/ImportExportWizardButtons.java?root=Tools_Project&r1=1.2.2.1&r2=1.2.2.2
[*] AbstractCPropertyTab.java 1.39.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractCPropertyTab.java?root=Tools_Project&r1=1.39.2.1&r2=1.39.2.2
[*] SymbolTab.java 1.16.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/SymbolTab.java?root=Tools_Project&r1=1.16.2.1&r2=1.16.2.2

[*] BuildJob.java 1.1.6.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/workingsets/BuildJob.java?root=Tools_Project&r1=1.1.6.1&r2=1.1.6.2

[*] MANIFEST.MF 1.53.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.53.2.2&r2=1.53.2.3

[-] Messages.properties  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.properties?root=Tools_Project&view=markup
[-] Messages.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/newui/Messages.java?root=Tools_Project&view=markup

[*] ExcludeFromBuildHandler.java 1.1.2.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/ExcludeFromBuildHandler.java?root=Tools_Project&r1=1.1.2.3&r2=1.1.2.4

[*] ExcludeFromBuildAction.java 1.10.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/actions/ExcludeFromBuildAction.java?root=Tools_Project&r1=1.10.2.1&r2=1.10.2.2