Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318787 - [Preferences] No control are made on command execution on PreferenceInitializerForElementHelper.java
Summary: [Preferences] No control are made on command execution on PreferenceInitializ...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.7.0   Edit
Assignee: Patrick Tessier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 318788 318962
  Show dependency tree
 
Reported: 2010-07-03 11:08 EDT by Thibault Landré CLA
Modified: 2010-07-06 09:25 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (884 bytes, application/octet-stream)
2010-07-06 05:49 EDT, Patrick Tessier CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Landré CLA 2010-07-03 11:08:37 EDT 
ShadowCommand, nameLabelIconCommand and qualifiedNameCommand are always executed which may cause errors on creating element. 

Moreover, this file doesn't have a copyright nor a licence. 

Patrick, I think it is one of your class, so I assign you this bug.
However I have already fixed the control part.
Comment 1 Thibault Landré CLA 2010-07-06 04:45:57 EDT 
Seems to have still some error at the initialisation of the preference. Do you have an idea Patrick ? 
(see 318962)
Comment 2 Patrick Tessier CLA 2010-07-06 05:49:46 EDT 
Created attachment 173519 [details]
mylyn/context/zip

commented classes
Comment 3 Patrick Tessier CLA 2010-07-06 05:58:09 EDT 
I have added a copyright.

It seems peculiar normally name label icon and qualified name commands  create only eannotation. if there is no editpolicy attached to the editpart to understand them, theses eannotation has no influence on your code.

Can you send me the errors, in order to solve it.
Comment 4 Thibault Landré CLA 2010-07-06 06:10:51 EDT 
see 318962
Comment 5 Patrick Tessier CLA 2010-07-06 06:19:33 EDT 
It seem that the bug comes from a NPE about the transactionalDomain. It will try to follow it.
Comment 6 Patrick Tessier CLA 2010-07-06 08:47:21 EDT 
This bug comes from  EditorUtils.getTransactionalEditingDomain() . It access to papyrus by looking for the active editor.
So EditorUtils.getTransactionalEditingDomain() return null and cannot execute command during the creation of the editor with this diagram
So I have open a test in order to test it.
the no anymore null pointer exception.
I have already discuss with Cedric because I have the same problem in the model explorer . I will add a new task about that.
Comment 7 Thibault Landré CLA 2010-07-06 09:25:22 EDT 
Ok, thanks