Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318645 - Duplicate menu contributions after editor switching
Summary: Duplicate menu contributions after editor switching
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 blocker (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 318853 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-01 15:32 EDT by Stefan Mücke CLA
Modified: 2010-07-08 05:27 EDT (History)
4 users (show)

See Also:


Attachments
Menu dispose v01 (1.67 KB, patch)
2010-07-06 12:54 EDT, Paul Webster CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Mücke CLA 2010-07-01 15:32:34 EDT
Build Identifier: Build id: I20100630-1856

Steps to reproduce: 

1. Open a Java file
2. Make sure the 'Source' menu is okay
3. Open a text file
4. Switch back to the Java file
5. Open the 'Source' menu again: all contributions are duplicated

Additional switching back and forth will add even more duplicates to the 'Source' menu.

Reproducible: Always
Comment 1 Remy Suen CLA 2010-07-05 07:33:41 EDT
*** Bug 318853 has been marked as a duplicate of this bug. ***
Comment 2 Remy Suen CLA 2010-07-05 09:30:35 EDT
We need to monitor the disposal of the 'Source' menu item and then perform the clean up in order to remove the model contributions. As is, the menu item and corresponding menu is recreated on-demand based on the active context.
Comment 3 Paul Webster CLA 2010-07-06 12:54:59 EDT
Created attachment 173579 [details]
Menu dispose v01

Make sure the model is cleaned up on a dispose

PW
Comment 4 Paul Webster CLA 2010-07-06 12:55:59 EDT
Released to HEAD
PW
Comment 5 Dani Megert CLA 2010-07-08 05:27:48 EDT
Verified in I20100707-2006.