Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318618 - Use URLImageDescriptor to load images
Summary: Use URLImageDescriptor to load images
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 10:46 EDT by Benjamin Muskalla CLA
Modified: 2010-08-12 13:04 EDT (History)
1 user (show)

See Also:

Attachments
patch (2.80 KB, patch)
2010-07-01 10:46 EDT, Benjamin Muskalla CLA 		andrew_johnson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-07-01 10:46:22 EDT 
Just a minor thing I noticed: MemoryAnalyserPlugin loads images itself from a URL. You can use URLImageDescriptor to save some code and get rid of the error handling.

And btw: missing_image.gif is missing ;-)
Comment 1 Benjamin Muskalla CLA 2010-07-01 10:46:46 EDT 
Created attachment 173223 [details]
patch

Patch
Comment 2 Andrew Johnson CLA 2010-08-12 11:52:50 EDT 
Good idea - thanks.

To follow the Eclipse Legal Process, please can you confirm that you
(a) wrote 100% of the code; 
(b) that you have the right to contribute the code to Eclipse; 
and that it is contributed under the Eclipse Public License.

For part c, the file has already has license header, but I'll add your name as a contributor.
(c) the file header contains the appropriate License header.
Comment 3 Benjamin Muskalla CLA 2010-08-12 11:58:20 EDT 
a) yep
b) yep
c) thanks

But I don't think I need to answer all these things as committer. I think only non-committers need to do that.
Comment 4 Andrew Johnson CLA 2010-08-12 13:04:21 EDT 
I've applied and committed the patch.

I think the committer status is on a project basis, so in the Eclipse legal process poster, figure 1 says "Written 100% by Submitting Committer or Committer on same Project under the supervision of the PMC", figure 3 says "Written 100% by Submitting Contributor (Non-Committer) and Submitted under the terms of the Project License (typically EPL)".