Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318613 - Improve context info in the deprecated version syntax message
Summary: Improve context info in the deprecated version syntax message
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 10:37 EDT by Scott Huff CLA
Modified: 2010-07-08 15:35 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
konstantin: pmc_approved? (raghunathan.srinivasan)
konstantin: pmc_approved? (naci.dai)
konstantin: pmc_approved? (deboer)
konstantin: pmc_approved? (neil.hauge)
konstantin: pmc_approved? (kaloyan)

Attachments
Patch (5.41 KB, patch)
2010-07-02 20:36 EDT, Konstantin Komissarchik CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Huff CLA 2010-07-01 10:37:46 EDT 
The message for deprecatedSyntaxNoPlugin should ideally give some form of identification about the offending plugin or extension; without that info, it is doubtful anyone will ever fix their deprecated code.

Message:

!ENTRY org.eclipse.wst.common.project.facet.core 2 0 2010-04-26 14:05:45.703
!MESSAGE The ">", ">=", "<", and "<=" notation in version expressions has been deprecated. Note that the angle brackets are represented via "&lt;" and "&gt;" in the plugin.xml files. The functionality has been replaced with range notation. For instance "[X-Y)" means all versions greater or equals to  X and less than Y. Open ranges such as "(X" or "Y]" are also allowed.
Comment 1 Konstantin Komissarchik CLA 2010-07-02 20:36:17 EDT 
Created attachment 173338 [details]
Patch

There was already code in place to report plugin id if the code path in question happened to have this information. The attached patch also adds reporting of the version expr string that was used as well as the facet that it was used with. That should help identify the use site.
Comment 2 Konstantin Komissarchik CLA 2010-07-02 20:40:39 EDT 
Raising for PMC approval for 3.2.1 as this change affects localization. Note that affect is very minor as the affected strings are used in a logged message meant for framework consumers rather than end users.
Comment 3 David Williams CLA 2010-07-07 01:56:07 EDT 
FYI, for PMC approval, it helps process to put "PMC" in whiteboard ... then it will show up in our PMC review summary pages, such as 
http://www.eclipse.org/webtools/plans/3.2.1/pmc-bug-approval.php
Comment 4 Konstantin Komissarchik CLA 2010-07-07 14:31:05 EDT 
Released the patch to WTP 3.2.1 and fproj 2.0 streams.