Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318558 - [NLS] Not Externalized String in Servlet Wizard
Summary: [NLS] Not Externalized String in Servlet Wizard
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.servlet (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Kaloyan Raev CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 04:34 EDT by Alexander Silgidjian CLA
Modified: 2010-07-08 15:34 EDT (History)
5 users (show)

See Also:
kaloyan: pmc_approved? (david_williams)
kaloyan: pmc_approved? (raghunathan.srinivasan)
kaloyan: pmc_approved? (naci.dai)
kaloyan: pmc_approved? (deboer)
neil.hauge: pmc_approved+
cbridgha: review+

Attachments
Screen shot (27.42 KB, image/jpeg)
2010-07-01 04:36 EDT, Alexander Silgidjian CLA 		no flags Details
patch (1.90 KB, patch)
2010-07-01 12:30 EDT, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Silgidjian CLA 2010-07-01 04:34:28 EDT 
Build Identifier: 20100617-1415

"!_JSP_UI!" label appears in Servlet Wizard.
For more details check the screenshot attached.

Reproducible: Always

Steps to Reproduce:
1. Create Web 2.5 Project
2. Create Servlet 
3. Start again Servlet Wizard
4. Check "Use an existing Servlet or JSP"
5. Click "Browse"

Result: A screenshot is attached.
Comment 1 Alexander Silgidjian CLA 2010-07-01 04:36:31 EDT 
Created attachment 173175 [details]
Screen shot
Comment 2 Kaloyan Raev CLA 2010-07-01 12:28:52 EDT 
I don't know how this happened, but the patch from bug 198937 applied to all files with the exception of webedit.properties.
Comment 3 Kaloyan Raev CLA 2010-07-01 12:30:20 EDT 
Created attachment 173238 [details]
patch

Patch for the missing change in webedit.properties.
Comment 4 Kaloyan Raev CLA 2010-07-01 12:30:59 EDT 
Chuck, please review this patch for 3.2.1.
Comment 5 Chuck Bridgham CLA 2010-07-02 10:35:23 EDT 
approved
Comment 6 Kaloyan Raev CLA 2010-07-02 11:00:16 EDT 
Raising for PMC review. 

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This bug solves a regression introduced with the Helios release. One UI label is corrupted. 

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No meaningful workaround. 

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manually tested. 

    * Give a brief technical overview. Who has reviewed this fix? 

The patch of bug 198937 was not applied to the webedit.properties file by mistake. This patch adds the missing bits from that patch. 

    * What is the risk associated with this fix? 

The changes affect some UI labels. No other technical risk.
Comment 7 Kaloyan Raev CLA 2010-07-02 11:34:10 EDT 
Committed to HEAD and released.