Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318517 - Refactoring: Loop Fusion
Summary: Refactoring: Loop Fusion
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 7.0   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 15:12 EDT by Ashley Kasza CLA
Modified: 2011-05-14 06:48 EDT (History)
2 users (show)

See Also:


Attachments
Loop Fusion Refactoring (28.78 KB, patch)
2010-06-30 15:12 EDT, Ashley Kasza CLA
g.watson: iplog+
Details | Diff
Revised patch - renamed, messages committed (36.39 KB, text/plain)
2010-09-21 11:08 EDT, Jeffrey Overbey CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ashley Kasza CLA 2010-06-30 15:12:05 EDT
Refactoring used to fuse two compatible loops together
Comment 1 Ashley Kasza CLA 2010-06-30 15:12:43 EDT
Created attachment 173148 [details]
Loop Fusion Refactoring

Loop Fusion Refactoring
Comment 2 Jeffrey Overbey CLA 2010-06-30 15:51:56 EDT
Thanks.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?
Comment 3 Ashley Kasza CLA 2010-07-14 14:55:45 EDT
1. I wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,

2. I have the right to contribute the code to Eclipse, and

3. I have included the EPL license header in all source files.
Comment 4 Jeffrey Overbey CLA 2010-09-21 11:08:38 EDT
Created attachment 179320 [details]
Revised patch - renamed, messages committed

I committed the externalized strings and plugin.xml changes to CVS, but the unit tests are not passing, so I did not commit the refactoring itself or the test suite.  Ashley, could you please replace your sources from HEAD (i.e., get rid of your local changes), then apply the REVISED patch (attached), and see why the tests are failing?  When it is fixed, please attach a revised revised patch.  Thanks.
Comment 5 Jeffrey Overbey CLA 2010-09-21 11:11:24 EDT
Oops, I attached that to the wrong bug.  That was for Unroll Loop.

Fuse Loops works fine.  It has been committed to CVS.  Thanks!