Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318506 - Revert button on Property Page is truncated in Japanese
Summary: Revert button on Property Page is truncated in Japanese
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 13:42 EDT by Eric Peters CLA
Modified: 2010-08-16 20:21 EDT (History)
2 users (show)

See Also:

Attachments
screen-capture of truncated text on Revert Button (830.48 KB, application/unknown)
2010-06-30 13:42 EDT, Eric Peters CLA 		no flags Details
Patch (2.20 KB, patch)
2010-07-16 13:51 EDT, Konstantin Komissarchik CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Peters CLA 2010-06-30 13:42:34 EDT 
Created attachment 173132 [details]
screen-capture of truncated text on Revert Button

JAX-RS property page extends org.eclipse.jst.common.project.facet.ui.libprov.LibraryFacetPropertyPage and the "Revert" button in Japanese install is truncated as per screen capture. JSF property page likely has same truncation but do not have Japanese install to verify.

To recreate, add JAX-RS facet to Dynamic web project, then bring up the JAX-RS property page.

Action to take: Expand button size, or use shorter translation?
Comment 1 Konstantin Komissarchik CLA 2010-06-30 14:13:46 EDT 
It looks to me that the button did expand. By default, the button size is the same as the ok/cancel/apply buttons. I don't read Japanese, so I cannot tell if this is truncated or not.

If this is an issue with translation, that needs to go to the Babel project. I don't know exactly how they handle issues.
Comment 2 Kit Lo CLA 2010-07-15 00:58:36 EDT 
This is not a translation problem. WTP is probably hard-coding the width of the button. If you change the label

revertButton = Revert

in

eclipse\plugins\org.eclipse.jst.common.project.facet.ui\org\eclipse\jst\common\project\facet\ui\libprov\LibraryFacetPropertyPage.properties

to something like

revertButton = Revert Revert Revert

you will see the truncation problem. Routing back to WTP for investigation.
Comment 3 Konstantin Komissarchik CLA 2010-07-16 13:51:32 EDT 
Created attachment 174522 [details]
Patch

Reproduced the problem. So we don't create this button, but since we change its label, we must also reset its layout data as what's set by JFace only works for the label that code initially sets.
Comment 4 Konstantin Komissarchik CLA 2010-07-16 13:53:28 EDT 
Released the changes to fproj 2.0 code stream. Will wait until WTP 3.2.2 stream opens and release there then. Thanks.
Comment 5 Konstantin Komissarchik CLA 2010-08-16 20:21:43 EDT 
Released the fix to 3.2.2 and 3.3.0 code streams.
Comment 6 Konstantin Komissarchik CLA 2010-08-16 20:21:58 EDT 
Fixed