Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318498 - Many toolbars on top of one another
Summary: Many toolbars on top of one another
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 12:27 EDT by Boris Bokowski CLA
Modified: 2010-07-20 13:23 EDT (History)
2 users (show)

See Also:

Attachments
screen shot (12.16 KB, image/png)
2010-06-30 12:28 EDT, Boris Bokowski CLA 		no flags Details
Screenshot depicting the horror in question. (10.39 KB, image/png)
2010-06-30 16:40 EDT, Remy Suen CLA 		no flags Details
Patch to dispose the existing TopRight control before setting the new one (1.00 KB, patch)
2010-07-07 09:17 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2010-06-30 12:27:55 EDT 
I don't know how to reproduce this. I'll attach a screenshot.
Comment 1 Boris Bokowski CLA 2010-06-30 12:28:34 EDT 
Created attachment 173122 [details]
screen shot
Comment 2 Remy Suen CLA 2010-06-30 12:29:43 EDT 
That looks a lot scarier than how it looks on XP.
Comment 3 Remy Suen CLA 2010-06-30 16:40:47 EDT 
Created attachment 173155 [details]
Screenshot depicting the horror in question.

1. Wipe your deltas.xml.
2. Ctrl+3 > JUnit. It should appear in the same stack as the 'Package Explorer'.
3. Ctrl+3 > Switch to the 'Debug' perspective
4. Ctrl+3 > JUnit. It should appear in the bottom stack.
5. Ctrl+3 > Package Explorer It should appear in the same stack as the 'Debug' view in the top.
6. Ctrl+3 > Switch to the 'Java' perspective
7. Activate the 'Package Explorer' view. See that the toolbar is still the 'JUnit' view's toolbar.
8. Activate the 'JUnit' view.

Depending on how squished your stack is, you may see some pretty strange stuff.
Comment 4 Remy Suen CLA 2010-07-06 18:34:45 EDT 
Eric, the bug is in LazyStackRenderer's showElementRecursive(MUIElement, List<MUIElement>) method.

Around line 234, the toolbar of the view from the other perspective is reparented appropriate to the correct CTabFolder, however, that CTabFolder's prior 'topRight' control is not disposed which explains why there's still a phantom toolbar lying around.
Comment 5 Eric Moffatt CLA 2010-07-07 09:17:51 EDT 
Created attachment 173646 [details]
Patch to dispose the existing TopRight control before setting the new one
Comment 6 Eric Moffatt CLA 2010-07-07 09:21:06 EDT 
Committed in >20100707. Applied the patch.