Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318493 - ExtractLocalVariableRefactoringTest float fails because of error in test
Summary: ExtractLocalVariableRefactoringTest float fails because of error in test
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 8.0   Edit
Assignee: Emanuel Graf CLA
QA Contact: Emanuel Graf CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 12:05 EDT by Tomasz Wesolowski CLA
Modified: 2010-07-01 03:23 EDT (History)
0 users

See Also:


Attachments
corrected test fixture (1.38 KB, patch)
2010-06-30 12:06 EDT, Tomasz Wesolowski CLA
emanuel: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Wesolowski CLA 2010-06-30 12:05:42 EDT
Build Identifier: 

The test fixture assumes that the literal 42.0 is of type float and expects to have the resulting variable of type `float`. This causes a false positive because a variable of type `double` is created (correctly).

Reproducible: Always
Comment 1 Tomasz Wesolowski CLA 2010-06-30 12:06:20 EDT
Created attachment 173117 [details]
corrected test fixture

Attaching a patch with the test fixture corrected to proper `float` and `double` tests
Comment 2 Emanuel Graf CLA 2010-07-01 02:51:50 EDT
fixed in 8.0 > 20100701
Comment 3 CDT Genie CLA 2010-07-01 03:23:05 EDT
*** cdt cvs genie on behalf of egraf ***
Bug 318493: ExtractLocalVariableRefactoringTest float fails because of error in test
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=318493>https://bugs.eclipse.org/bugs/show_bug.cgi?id=318493</a>

[*] ExtractLocalVariable.rts 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractLocalVariable.rts?root=Tools_Project&r1=1.4&r2=1.5