Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318395 - [tcf] Fix and improve tracing of incoming CONF_SLAVES_INFO in java reference implementation
Summary: [tcf] Fix and improve tracing of incoming CONF_SLAVES_INFO in java reference ...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.4.0   Edit
Assignee: Project Inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 19:23 EDT by John Cortell CLA
Modified: 2013-06-05 07:56 EDT (History)
3 users (show)

See Also:

Attachments
fix (2.45 KB, patch)
2010-06-29 19:24 EDT, John Cortell CLA 		john.cortell: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-06-29 19:23:57 EDT 
Bug: each entry in an incoming CONF_SLAVES_INFO packet is  being logged as a distinct packet.

Improvement: dump the contents of an incoming CONF_SLAVES_INFO. I.e., show what slaves are being reported to us.
Comment 1 John Cortell CLA 2010-06-29 19:24:50 EDT 
Created attachment 173053 [details]
fix
Comment 2 Eugene Tarassov CLA 2010-06-30 18:32:50 EDT 
Committed. Thanks!
Comment 3 John Cortell CLA 2010-06-30 20:11:55 EDT 
Eugene, I think the iplog flag is to identify contributions that are not from Eclipse committers. A patch from a committer in another project is considered equally "clean", I believe. I'm a committer on the CDT project.
Comment 4 Eugene Tarassov CLA 2010-06-30 21:14:05 EDT 
(In reply to comment #3)
> Eugene, I think the iplog flag is to identify contributions that are not from
> Eclipse committers. A patch from a committer in another project is considered
> equally "clean", I believe. I'm a committer on the CDT project.
OK
Comment 5 Pawel Piech CLA 2010-06-30 23:38:18 EDT 
(In reply to comment #3)
> Eugene, I think the iplog flag is to identify contributions that are not from
> Eclipse committers. A patch from a committer in another project is considered
> equally "clean", I believe. I'm a committer on the CDT project.

Nope, all contributions from non-committers to the given project need to be noted in the project's IP log.  If a project has multiple components with separate commit rights for each component (like platform) then you don't need to enter the contribution in the log.
Comment 6 John Cortell CLA 2010-06-30 23:45:04 EDT 
(In reply to comment #5)
> Nope, all contributions from non-committers to the given project need to be
> noted in the project's IP log.  If a project has multiple components with
> separate commit rights for each component (like platform) then you don't need
> to enter the contribution in the log.

That doesn't make sense to me, as all committers are bound by the same set of  rules regarding IP, but certainly not worth further discussion. I'll revert the ipflag.
Comment 7 Doug Schaefer CLA 2011-05-17 10:49:18 EDT 
Moving bugs to new home for IP log.
Comment 8 Martin Oberhuber CLA 2013-06-05 06:26:43 EDT 
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3