Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318393 - Last of the non-CamelCase
Summary: Last of the non-CamelCase
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 18:49 EDT by Paul Webster CLA
Modified: 2010-07-05 14:15 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-29 18:49:22 EDT
There are still a few attributes that don't conform to our pattern.

iconURI, contributionURI, parentID in MenuContributions only, etc.

These should be fixed, but re-generating the code and re-factoring will be a larger commit.

PW
Comment 1 Thomas Schindl CLA 2010-07-05 11:35:47 EDT
I'm a bit indifferent on this. If we want to do it we need to do it today! Can we discuss for a moment on IRC?
Comment 2 Thomas Schindl CLA 2010-07-05 11:38:29 EDT
Boris & John, what do you think. We should react in the next few days (if we want to make the change we should not wait for the e4 call on thursday!).

I'm out for a business trip Tues/Wed but could try to prepare a patch today.
Comment 3 Thomas Schindl CLA 2010-07-05 11:39:31 EDT
... the really bad thing is that we'd break ALL early adopters with this so probably a mail on e4-dev should be sent out.
Comment 4 Thomas Schindl CLA 2010-07-05 11:57:04 EDT
I've identified the following attributes:

The following attributes will be affected by the change:
* UILabel#iconURI
* Contribution#contributionURI
* Input#inputURI
* MenuContribution#parentID
* PartDescriptor#contributionURI

The good thing is that people should able to fix them quite easily with a text editor because we are not changing any containments, ... .
Comment 5 Thomas Schindl CLA 2010-07-05 12:13:51 EDT
We decided on IRC only to change parentID and leave URI because this is at least consistent with how Java uses the term URI (e.g. File.toURI(), ...) and the breaking change is much much smaller
Comment 6 Thomas Schindl CLA 2010-07-05 12:36:00 EDT
released the parentID => parentId change to HEAD
Comment 7 Remy Suen CLA 2010-07-05 12:48:01 EDT
(In reply to comment #6)
> released the parentID => parentId change to HEAD

The failing tests have also just been corrected.
Comment 8 Paul Webster CLA 2010-07-05 14:15:17 EDT
Released update to UIEvents to be consistent.

PW