Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318392 - [NLS] Problems modifying the Deploy Path of the source Modules on the Deployment Assembly Page
Summary: [NLS] Problems modifying the Deploy Path of the source Modules on the Deploym...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 18:42 EDT by Jason Sholl CLA
Modified: 2010-07-08 15:34 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
jsholl: pmc_approved? (raghunathan.srinivasan)
jsholl: pmc_approved? (naci.dai)
jsholl: pmc_approved? (deboer)
jsholl: pmc_approved? (neil.hauge)
jsholl: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
patch for 3.2.1 (15.93 KB, patch)
2010-06-29 18:45 EDT, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2010-06-29 18:42:38 EDT 
Steps  to follow:
1.- Create a EAR with the default modules
2.- Open the Deployment Assembly of the EJB (Connector, WebProject, AppClient) 
3.- Modify the Deploy Path field of the /ejbModule (/connectorModule, /WebContent, /appClientModule  ) 
4.- Click OK 
5.- An exception is thrown
6.- Try to open the Deployment Assembly Page and a error dialog is shown (see image included)
7.- When the Deployment Assembly is displayed the Manifest Entries tab looks empty

The changes included in this patch are:
- Adding a 'Revert' and 'Apply' button the the Deployment Assembly window (both tabs).
- Adding the verify() method to the modify() method, so that changing the deploy path causes validation to reset.
- Adding checks to make sure the Manifest file exists before updating or reading it.
- Disabling buttons in the Manifest Entries tab if the Manifest file exists.
- The WorkbenchComponentImpl currently has caching issues with its defaultSourceRoot. This value is not being reset when resource mappings are removed.
Comment 1 Jason Sholl CLA 2010-06-29 18:45:08 EDT 
Created attachment 173052 [details]
patch for 3.2.1
Comment 2 Jason Sholl CLA 2010-06-29 18:50:37 EDT 
Requesting PMC approval because of a new string, "Revert".
Comment 3 Chuck Bridgham CLA 2010-06-30 23:04:12 EDT 
approved
Comment 4 David Williams CLA 2010-07-01 13:20:35 EDT 
approving (for next weeks build, not 7/1, as doesn't appear blocking). 

I've added "PII" to keywords, as I think that is our convention to help Babel or or other translators find changes that might need a new translation. (Well, they'll see the changes with their tools ... but, marking can help size before using the tools, or see the explanation of why needed, etc.).
Comment 5 David Williams CLA 2010-07-01 15:20:51 EDT 
doh, I just realized you had [NLS] in title ... so, never mind my comment about pii keyword ... I'm not sure what the best approach is ... but sounds like you already knew to flag it, so one way or the other is fine by me.
Comment 6 Jason Sholl CLA 2010-07-01 15:36:31 EDT 
checked into head for wtp 3.2.1