Description Nicolas Rouquette 2010-06-29 15:19:23 EDT

There is a subtle bug in the ECF framework that results in a double encoding of HTTP post/get/put requests.

The methods RestClientService::prepare[X]Method for X = Post, Get, Put follow the same pattern to set the request query string from the request parameters:

		HttpMethod result =...

		NameValuePair[] params = toNameValuePairs(uri, call, callable);
		if (params != null)
			result.setQueryString(params);
		return result;
		
According to doc, org.apache.commons.httpclient.HttpMethod.setQueryString(NameValuePair[]) already encodes the name value pairs.
This is on top of the encoding that RestClientService::toNameValuePairs() currently does, resulting in doubly encoded name/value pairs in the query string.

The suggested fix is to simply remove the encoding in RestClientService::toNameValuePairs() as shown in the attached patch.