Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318322 - Add "set solib-absolute-prefix" command
Summary: Add "set solib-absolute-prefix" command
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 09:47 EDT by Anna Dushistova CLA
Modified: 2010-07-06 15:23 EDT (History)
2 users (show)

See Also:
nobody: review+

Attachments
patch that adds the command (10.66 KB, patch)
2010-07-01 14:59 EDT, Anna Dushistova CLA 		marc.khouzam: iplog+
marc.khouzam: review+
Details | Diff
Committed fix (3.43 KB, patch)
2010-07-06 09:52 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
mylyn/context/zip (21.42 KB, application/octet-stream)
2010-07-06 09:52 EDT, Marc Khouzam CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Dushistova CLA 2010-06-29 09:47:27 EDT 
I'd like to be able to set solib-absolute-prefix via DSF.
Comment 1 Marc Khouzam CLA 2010-07-01 06:54:37 EDT 
Add MIGDBSetSolibAbsolutePrefix which extends MIGDBSet, and add it to the CommandFactory.

Maybe we can fix Bug 229288 at the same time.
Comment 2 Anna Dushistova CLA 2010-07-01 14:59:04 EDT 
Created attachment 173253 [details]
patch that adds the command
Comment 3 Marc Khouzam CLA 2010-07-06 09:52:20 EDT 
Created attachment 173551 [details]
Committed fix
Comment 4 Marc Khouzam CLA 2010-07-06 09:52:21 EDT 
Created attachment 173552 [details]
mylyn/context/zip
Comment 5 Marc Khouzam CLA 2010-07-06 09:54:21 EDT 
Mikhail, can you review?
Comment 6 Marc Khouzam CLA 2010-07-06 09:55:24 EDT 
Anna, just a note about import preferences:
please change the "Number of imports needed for .*" to something bigger than 99.  I have 999.
You can find that pref in Java->Organize Imports, towards the bottom.
This will avoid replacing most imports in CommandFactory with a *
Comment 7 Marc Khouzam CLA 2010-07-06 09:56:42 EDT 
The fix I committed simply changed the context type of the new MIGDBSetSolibAbsolutePrefix to be ICommandControlDMContext
Comment 8 Nobody - feel free to take it CLA 2010-07-06 10:00:36 EDT 
Looks good. Don't know much about mylyn attachment though.
Comment 9 Marc Khouzam CLA 2010-07-06 10:05:08 EDT 
(In reply to comment #8)
> Looks good. Don't know much about mylyn attachment though.

:-)
I just started to use Mylyn and it automatically attached the context.  I guess that is a good thing for history...  I'll ask Andrew G, he uses Mylyn a lot.
Comment 11 Nobody - feel free to take it CLA 2010-07-06 13:28:04 EDT 
The since tag for the command factory call is missing. Do you want me to add it?
Comment 12 Marc Khouzam CLA 2010-07-06 14:29:41 EDT 
(In reply to comment #11)
> The since tag for the command factory call is missing. Do you want me to add it?

Sorry about that.  For some reason I did not get a compile error.  I had to clean my project to finally see it.  I've committed a fix.