318257 – Remove obsolete plugin "org.eclipse.e4.ui.workbench3" from releng

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318257 - Remove obsolete plugin "org.eclipse.e4.ui.workbench3" from releng

Summary: Remove obsolete plugin "org.eclipse.e4.ui.workbench3" from releng

Status:	RESOLVED WONTFIX

Alias:	None

Product:	e4
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-06-28 17:47 EDT by Lars Vogel
Modified:	2010-06-30 15:11 EDT (History)
CC List:	5 users (show)

See Also:

Attachments
Releng-Update (1.06 KB, text/plain) 2010-06-28 17:49 EDT, Lars Vogel	no flags	Details
Deletion of org.eclipse.e4.ui.workbench3 content (7.05 KB, application/octet-stream) 2010-06-28 17:50 EDT, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2010-06-28 17:47:37 EDT

Comment 1 Lars Vogel

2010-06-28 17:49:40 EDT

Created attachment 172973 [details]
Releng-Update

org.eclipse.e4.ui.workbench3 is still included in "e4.ui.psf" from org.eclipse.e4.ui.releng. 

I checked in IRC and this plugin is not required anymore 

Please find a patch attached this cleans-up the releng, deletes the content of org.eclipse.e4.ui.workbench3 and adds a readme.txt that org.eclipse.e4.ui.workbench3 is obsolete.

Comment 2 Lars Vogel

2010-06-28 17:50:16 EDT

Created attachment 172974 [details]
Deletion of org.eclipse.e4.ui.workbench3 content

Comment 3 Lars Vogel

2010-06-28 19:25:56 EDT

I just realized that "org.eclipse.e4.ui.workbench.renderers.swt" still depends on "org.eclipse.e4.ui.workbench3". Is this intended?

Comment 4 Lars Vogel

2010-06-28 19:30:34 EDT

@Boris: according to the IRC you are the one who knows if this plugin is still needed.

Comment 5 Boris Bokowski

2010-06-29 00:42:53 EDT

The reason for this bundle is captured in bug 296599 - it was created so that you can run JUnit tests for native e4 apps that require the system to be up and running. I am not sure if this is still required since I think you would normally structure your tests to be independent of the framework being initialized.

Long term, the bundle was meant as a place for 3.x API that is needed for native e4 apps.

Comment 6 Lars Vogel

2010-06-29 09:36:29 EDT

Thanks for clarification Boris.

FYI: Currently "org.eclipse.e4.ui.workbench.renderers.swt" uses
some "org.eclipse.e4.ui.workbench3" functionality. 

Shall I set this bug to "Won't fix"?

Comment 7 Boris Bokowski

2010-06-29 18:07:38 EDT

Not sure.. Paul, I noticed that the classes in this bundle also exist in the 4.0 org.eclipse.ui.workbench - shouldn't we try to have only one copy?

Comment 8 John Arthorne

2010-06-30 15:11:19 EDT

(In reply to comment #7)
> Not sure.. Paul, I noticed that the classes in this bundle also exist in the
> 4.0 org.eclipse.ui.workbench - shouldn't we try to have only one copy?

I think the issue is that e4 bundles are using this API. So, if we leave it in org.eclipse.ui.workbench then the e4 workbench will depend on 3.x workbench, which isn't ideal. Longer term we probably need to break up org.eclipse.ui.workbench to separate deprecated/obsolete concepts from API that is still useful in e4. That would allow e4 bundles to use 3.x API such as this without dragging in extra junk. I think bug 316196 can be used to track that, and we can just close this one as WONTFIX.