Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318236 - [CSS] WindowMargins and CTabRendering not applied without a theme
Summary: [CSS] WindowMargins and CTabRendering not applied without a theme
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-28 15:51 EDT by Thomas Schindl CLA
Modified: 2010-06-28 16:09 EDT (History)
2 users (show)

See Also:

Attachments
patch (14.57 KB, patch)
2010-06-28 15:57 EDT, Thomas Schindl CLA 		no flags Details | Diff
patch (12.53 KB, patch)
2010-06-28 16:06 EDT, Thomas Schindl CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-28 15:51:00 EDT 
We still have a system in place for very small applications where creating a theme is overhead. Applying the margins and the CTabRendering is not working in this case. We are also leaking the CSSEngineImpl through our IThemeEngine-Service which is not really optimal (Susan already added a comment when she added the code).
Comment 1 Thomas Schindl CLA 2010-06-28 15:56:09 EDT 
One can easily test this with the Photo-Demo which is not using our themeing system to apply CSS styling.
Comment 2 Thomas Schindl CLA 2010-06-28 15:57:21 EDT 
Created attachment 172947 [details]
patch

This patches removes the leaking of the CSSEngine and fixes the margins problem - I haven't found out yet why the CTabRendering is not working
Comment 3 Thomas Schindl CLA 2010-06-28 16:06:47 EDT 
Created attachment 172948 [details]
patch

fix for the CTabRendering
Comment 4 Thomas Schindl CLA 2010-06-28 16:09:16 EDT 
released changes to HEAD
Comment 5 Thomas Schindl CLA 2010-06-28 16:09:51 EDT 
Yves, please check if my changes to your XWT-Code as correct