Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318119 - [editor] Save flashes XMI
Summary: [editor] Save flashes XMI
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.0.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: OCL Inbox CLA
QA Contact: Ed Willink CLA
URL:
Whiteboard: Usability
Keywords:
Depends on:
Blocks: 318358
  Show dependency tree
 
Reported: 2010-06-27 05:37 EDT by Ed Willink CLA
Modified: 2011-05-27 03:13 EDT (History)
1 user (show)

See Also:
ed: indigo+
ed: review? (adolfosbh)
ed: review? (alexander.igdalov)

Attachments
Fix (9.79 KB, patch)
2010-06-30 03:30 EDT, Ed Willink CLA 		no flags Details | Diff
Cleaner version avoiding subtle overrides (9.23 KB, patch)
2010-06-30 04:28 EDT, Ed Willink CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2010-06-27 05:37:59 EDT 
On a fairly fresh Helios Modeling package installation.

Create new EMF project.
Create new Ecore file.
....
open as OCLinEcore editor.

Add missing package name.
Save.  XMI appears transiently.
Comment 1 Ed Willink CLA 2010-06-30 03:30:59 EDT 
Created attachment 173067 [details]
Fix

Attached necessary fix:

Avoids a transient change of the document to XMI that causes listeners to display and parse it. Instead, the provision of text to the get() from save is deceived into storing the XMI.

Also tidy up for:

Eliminate workaround for fixed Bug 309383.
Generate an error log rather than console trace on save failure.

----

This seems a candidate for 3.0.1.
Comment 2 Ed Willink CLA 2010-06-30 04:28:04 EDT 
Created attachment 173069 [details]
Cleaner version avoiding subtle overrides
Comment 3 Alexander Igdalov CLA 2010-07-01 11:16:53 EDT 
Hi Guys,

I will be glad to review the patch but please don't expect a quick response - I've just relocated :-)))

Cheers,
- Alex.
Comment 4 Ed Willink CLA 2010-08-17 17:07:18 EDT 
Committed to HEAD for 3.1.0M2 and to R3_0_maintenance for 3.0.1RC2.
Comment 5 Ed Willink CLA 2011-05-27 03:13:47 EDT 
Closing