Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318071 - "Go to Language Definition" should be available along more paths
Summary: "Go to Language Definition" should be available along more paths
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.7   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-26 04:17 EDT by Stephan Herrmann CLA
Modified: 2010-07-02 13:20 EDT (History)
0 users

See Also:

Attachments
proposed implementation part 1 (25.80 KB, patch)
2010-06-27 18:16 EDT, Stephan Herrmann CLA 		no flags Details | Diff
Implementation part 2 (6.89 KB, patch)
2010-06-27 19:22 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-06-26 04:17:47 EDT 
When the compiler reports an OT/J specific problem the Problems view
has a context menu action "Go to Language Definition".

This action should be available along more paths:
 - from the problem marker in the left gutter
 - from the hover of the problem, if possible
   (perhaps as another button next to "Configure Problem Severity")
Comment 1 Stephan Herrmann CLA 2010-06-27 18:16:22 EDT 
Created attachment 172862 [details]
proposed implementation part 1

This patch implements part 1, i.e., the action in the gutter's context menu.

The structure is a bit more involved than expected because:
 - the otdt.ui plug-in which holds the current UpdateRulerAction should not 
   depend on otdt.ui.help
 - installing a new UpdateRulerAction from otdt.ui.help wasn't effective 
   if this plugin wasn't activated when contributions were initialized
   (see EditorPluginAction.editorChanged() -> isOkToCreateDelegate()).

Therefore, I created a new extension point in otdt.ui allowing otdt.ui.help
to register an extender that hooks into the existing UpdateRulerAction.

The rest of the implementation is mostly straight-forward.
Comment 2 Stephan Herrmann CLA 2010-06-27 19:22:34 EDT 
Created attachment 172864 [details]
Implementation part 2

This little team class adds a "Go to Language Definition" button to the
toolbar of a java problem hover, if the problem is indeed OT/J related.
Comment 3 Stephan Herrmann CLA 2010-06-27 19:27:58 EDT 
Implementation has been committed as r537 - r541.
Comment 4 Stephan Herrmann CLA 2010-07-02 13:20:08 EDT 
Verified using build 201007011455.