Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318069 - Publish occurs during server creation when publish after start preference has been disabled
Summary: Publish occurs during server creation when publish after start preference has...
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Elson Yuen CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 23:05 EDT by Elson Yuen CLA
Modified: 2017-10-11 16:33 EDT (History)
0 users

See Also:
arvera: review+

Attachments
v1.0 (1.34 KB, patch)
2010-06-28 17:06 EDT, Elson Yuen CLA 		arvera: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elson Yuen CLA 2010-06-25 23:05:19 EDT 
Build Identifier: WTP 3.2

During server creation, there is a case where the framework will triggers a server publish even when publish after start is disabled on the preference page.


Reproducible: Always
Comment 1 Elson Yuen CLA 2010-06-25 23:10:01 EDT 
The problem is caused by auto publish is triggered when the ServerBehaviourDelegate is being created.  However, the publish after server start flag on the preference page has not been checked before calling auto publish.

Please assign this defect to me.
Comment 2 Elson Yuen CLA 2010-06-28 17:06:06 EDT 
Created attachment 172967 [details]
v1.0

The fix is to add the ServerCore.isAutoPublishing() flag check before kicking off an autopublish when the ServerBehaviourDelegate is initialized. This will make first initialization of the ServerBehaviourDelegate respect that publish after server start flag.
Comment 3 Angel Vera CLA 2010-06-29 10:43:55 EDT 
Thanks Elson. 

The patch looks good,I just made the comments shorter. 

This looks like a change for 3.2.1, as the preference (PREF_AUTO_PUBLISH) should be respected in all cases.
Comment 4 Angel Vera CLA 2010-06-29 10:46:39 EDT 
Changes committed to 32M
Comment 5 Angel Vera CLA 2010-06-29 10:48:23 EDT 
Changes committed to HEAD
Comment 6 Angel Vera CLA 2010-07-09 10:58:37 EDT 
Changes already released to HEAD and 32M
Comment 7 Eclipse Genie CLA 2017-10-11 16:33:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/108964