Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318051 - [remote debug] Terminating when "Remote shell" process is selected doesn't work
Summary: [remote debug] Terminating when "Remote shell" process is selected doesn't work
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.1.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 368597
  Show dependency tree
 
Reported: 2010-06-25 17:28 EDT by Anna Dushistova CLA
Modified: 2012-02-29 13:22 EST (History)
3 users (show)

See Also:


Attachments
Patch that fixes the problem for both DSF and CDI launches (11.77 KB, patch)
2012-01-24 10:29 EST, Anna Dushistova CLA
marc.khouzam: iplog+
marc.khouzam: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Dushistova CLA 2010-06-25 17:28:21 EDT
1)terminating when the Remote Shell is selected does not work.  This also
does not work in CDI.
2)when terminating with other elements selected, it works, except that the
launch is not marked as terminated and the 'remove terminated launch' button
remains disabled.  This could be an unrelated issue see Bug 312267.
Comment 1 Anna Dushistova CLA 2012-01-24 10:29:23 EST
Created attachment 209974 [details]
Patch that fixes the problem for both DSF and CDI launches
Comment 2 Marc Khouzam CLA 2012-01-24 11:14:37 EST
Thanks Anna, I committed the patch to master.

I also increased the plugin version from 2.3 to 2.4.
Comment 3 Andrew Gvozdev CLA 2012-01-24 17:48:49 EST
(In reply to comment #2)
> I also increased the plugin version from 2.3 to 2.4.
And I fixed the version in pom.xml which needs to match plugin version.
Comment 4 Marc Khouzam CLA 2012-01-24 21:49:12 EST
(In reply to comment #3)
> (In reply to comment #2)
> > I also increased the plugin version from 2.3 to 2.4.
> And I fixed the version in pom.xml which needs to match plugin version.

Thanks Andrew!
Comment 5 CDT Genie CLA 2012-02-29 13:22:03 EST
*** cdt git genie on behalf of Anna Dushistova ***

    Bug 318051: Terminating when "Remote shell" process is selected doesn't work

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=e25a3409383dc97f68cd39ac5a6d5dfac36402fa
Comment 6 CDT Genie CLA 2012-02-29 13:22:08 EST
*** cdt git genie on behalf of Andrew Gvozdev ***

    Bug 318051: version in pom.xml needs to match manifest

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=4322fac5aaa2912f24ea470509c6b6be78ac713d