Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 318043 - WorkbenchSWTActivator should be internal
Summary: WorkbenchSWTActivator should be internal
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 16:27 EDT by John Arthorne CLA
Modified: 2010-06-27 23:17 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2010-06-25 16:27:41 EDT 
Currently WorkbenchSWTActivator is in an API package. Activators shouldn't be API because it allows clients to call start() and stop(). Also this class just exposes a bunch of tempting singletons that should really be accessed in other ways (preferably through a context or injected).
Comment 1 John Arthorne CLA 2010-06-25 16:52:34 EDT 
Fix released.
Comment 2 Thomas Schindl CLA 2010-06-27 03:28:16 EDT 
This broke XWT-Designer which was referencing this activator. I've released a fix.
Comment 3 John Arthorne CLA 2010-06-27 23:17:36 EDT 
Sorry! I usually have all the XWT projects loaded but I had closed them because synching my workspace was taking too long.