Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317975 - Fix for wrong usages of affect* and effect*
Summary: Fix for wrong usages of affect* and effect*
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 09:28 EDT by Markus Keller CLA
Modified: 2011-01-18 00:53 EST (History)
2 users (show)

See Also:

Attachments
Fix (79.52 KB, patch)
2010-06-25 09:28 EDT, Markus Keller CLA 		no flags Details | Diff
Fix for org.eclipse.core.variables (1.01 KB, patch)
2010-06-25 09:33 EDT, Markus Keller CLA 		no flags Details | Diff
updated patch (17.71 KB, patch)
2010-12-10 14:59 EST, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-06-25 09:28:33 EDT 
Created attachment 172745 [details]
Fix

N20100620-2000

Here's a fix for wrong usages of affect* (usually a verb) and effect* (usually a noun). For further information, see e.g.
http://www.merriam-webster.com/video/affectvseffect.htm and
http://www.wsu.edu/~brians/errors/affect.html

The patch also contains fixes for Ant, Platform Debug, and PDE.
Comment 1 Markus Keller CLA 2010-06-25 09:33:55 EDT 
Created attachment 172746 [details]
Fix for org.eclipse.core.variables

An additional patch for org.eclipse.core.variables.
Comment 2 Markus Keller CLA 2010-12-09 12:36:35 EST 
Ping
Comment 3 Michael Rennie CLA 2010-12-10 14:59:18 EST 
Created attachment 184990 [details]
updated patch

This debug-only patch rolls in the updates to core.variables and updates the copyrights.
Comment 4 Michael Rennie CLA 2010-12-13 10:44:16 EST 
applied patch to HEAD.

Thanks Markus.
Comment 5 Pawel Piech CLA 2011-01-18 00:53:09 EST 
This was quite a big patch!  BTW, isn't Darin's mom an English teacher?