Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317914 - Empty elements in toolbar of Eclipse 4.0 SDK
Summary: Empty elements in toolbar of Eclipse 4.0 SDK
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 02:04 EDT by Lars Vogel CLA
Modified: 2010-07-05 13:39 EDT (History)
1 user (show)

See Also:

Attachments
Toolbar (3.19 KB, image/gif)
2010-06-25 02:04 EDT, Lars Vogel CLA 		no flags Details
Hide empty toolbars (2.33 KB, patch)
2010-07-05 13:32 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2010-06-25 02:04:28 EDT 
Created attachment 172708 [details]
Toolbar

The Eclispe 4.0 SDK shows empty elements in the toolbar. I attached a screenshot and highlighted the empty areas.

Build ID: I20100623-1410
Comment 1 Eric Moffatt CLA 2010-07-05 13:32:07 EDT 
Created attachment 173461 [details]
Hide empty toolbars


This simply sets the TBR of the added MToolBars based on the simplest of tests; there must be at least one visible (TBR==true) non-separator child...
Comment 2 Eric Moffatt CLA 2010-07-05 13:39:09 EDT 
Committed in >20100705. Applied the patch.

I'll mark this as FIXED but feel free to re-open if you find examples of 'empty' TB's being displayed...