Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317844 - [explorer] NamespaceGroups not provided for JavaScript files
Summary: [explorer] NamespaceGroups not provided for JavaScript files
Status: CLOSED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 11:30 EDT by Ian Tewksbury CLA
Modified: 2010-07-09 08:39 EDT (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
Fix Patch (8.37 KB, patch)
2010-06-24 11:31 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2010-06-24 11:30:24 EDT 
Currently NamespaceGroups are only provided for under the JavaScript Resources node for the various JavaScript libraries and source folders.  This means that when expanding a library or source folder under the JavaScript Resources node by default types are listed under namespace groups (package fragment groups).  But this does not hold true when expanding a JavaScript file.  When performing this action all of the types defined in that file are listed in alphabetical order with no namespace separation.

I am attaching a patch that updates NamespaceGroup to function under a IJavaScriptUnit node (a JS file node) and updating the PackageExplorerContentProvider to create these NamespaceGroup nodes for IJavaScriptUnit nodes.
Comment 1 Ian Tewksbury CLA 2010-06-24 11:31:09 EDT 
Created attachment 172624 [details]
Fix Patch

The patch as described in the description.
Comment 2 Chris Jaun CLA 2010-06-28 15:08:39 EDT 
Patch checked in by Nitin.
Comment 3 Ian Tewksbury CLA 2010-07-09 08:39:27 EDT 
Verified in WTP 3.2.1