Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317807 - Comparator-Support for TreeRidget
Summary: Comparator-Support for TreeRidget
Status: NEW
Alias: None
Product: Riena
Classification: RT
Component: ridget (show other bugs)
Version: 2.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1.0.M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 08:24 EDT by Nobody - feel free to take it CLA
Modified: 2010-07-16 03:18 EDT (History)
2 users (show)

See Also:

Attachments
Patch (8.33 KB, text/plain)
2010-06-24 09:18 EDT, Nobody - feel free to take it CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2010-06-24 08:24:47 EDT 
We need Comparator-Support for the TreeRidget. At this time TreeItems are allways added as the last child of the parent-TreeItem ignoring any domain specifix order of the underlying model. A ViewerComparator has to be implemented for the TreeViewer. ITreeRidget has to provider an API for registration of Comparators similar to the ITableRidget.
Comment 1 Nobody - feel free to take it CLA 2010-06-24 09:18:44 EDT 
Created attachment 172603 [details]
Patch
Comment 2 Elias Volanakis CLA 2010-06-28 20:51:55 EDT 
Quickly looked at this and it looks good.

Just one question: what does the change SubModuleComparator do (from the patch)? If I understand correctly the submodule-nodes will be ordered by their order in the model instead of the creation order?
Comment 3 Elias Volanakis CLA 2010-06-28 20:55:02 EDT 
One more thing: for IP compliance reasons please confirm in a bugzilla comment that the following statements apply:

(a) you are a compeople employee
(b) Compeople has a member committer agreement with the Eclipse Foundation
(c) you wrote this code yourself, without using any 3rd party code

(if you 've questions talk with Christian)

I will then commit the patch.
Comment 4 Elias Volanakis CLA 2010-07-15 19:09:43 EDT 
You are a committer, so comment #3 is obsolete. But Christian mentioned to hold off committing this some time ago (forgot the reason).
Comment 5 Christian Campo CLA 2010-07-16 03:18:02 EDT 
Yes we are holding this back for a little more while, since it seems a pretty fundamental change for Trees and need to make sure that it has no sideeffects and we dont want to destabilize the HEAD at this point in time....